[CLEANUP] Cleanup IE11 leftovers#19575
[CLEANUP] Cleanup IE11 leftovers#19575simonihmig wants to merge 5 commits intoemberjs:v4-cleanupfrom
Conversation
After dropping IE11 support, all supported browsers support symbols natively.
After dropping IE11 support, all supported browsers support proxies natively.
|
@simonihmig small correction to the description: |
|
Oh, right, corrected. Thanks! |
mixonic
left a comment
There was a problem hiding this comment.
Very cool. This might have been easier as a distinct PR for each change, but I'm mostly comfortable with it after scrolling through it.
Left two notes to get clarity on.
| import { extractRouteArgs, resemblesURL, shallowEqual } from '../utils'; | ||
|
|
||
| const ROUTER = symbol('ROUTER') as string; | ||
| const ROUTER = (symbol('ROUTER') as unknown) as string; |
There was a problem hiding this comment.
What is the motivation for this change?
| version "7.12.1" | ||
| resolved "https://registry.yarnpkg.com/@babel/plugin-transform-for-of/-/plugin-transform-for-of-7.12.1.tgz#07640f28867ed16f9511c99c888291f560921cfa" | ||
| integrity sha512-Zaeq10naAsuHo7heQvyV0ptj4dlZJwZgNAtBYBnu5nNKJoW62m0zKcIEyVECrUKErkUkg6ajMy4ZfnVZciSBhg== | ||
| dependencies: |
There was a problem hiding this comment.
Should there be yarn.lock changes in this PR? I think not?
There was a problem hiding this comment.
Probably somehow by accident, removed that in my reopened PR!
|
Bah, I thought this would just update to point at master :( |
|
@simonihmig this PR was auto-closed when |
Further cleanup after dropping IE11 support: (best reviewed commit after commit)