Skip to content

[CLEANUP] Remove deprecated mouse events#19529

Closed
btecu wants to merge 1 commit intoemberjs:v4-cleanupfrom
btecu:mouse
Closed

[CLEANUP] Remove deprecated mouse events#19529
btecu wants to merge 1 commit intoemberjs:v4-cleanupfrom
btecu:mouse

Conversation

@btecu
Copy link
Contributor

@btecu btecu commented May 3, 2021

No description provided.

@simonihmig simonihmig mentioned this pull request May 24, 2021
Closed
simonihmig
simonihmig reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging #19227 has caused some conflicts here, sorry about that! 😉

One test is failing in CI, I haven't really been able to identify it by looking through the logs though...

packages/@ember/-internals/views/lib/system/event_dispatcher.js Outdated
// Mimics the way this is handled in jQuery,
// see https://github.com/jquery/jquery/blob/899c56f6ada26821e8af12d9f35fa039100e838e/src/event.js#L666-L700
if (MOUSE_ENTER_LEAVE_MOVE_EVENTS && EVENT_MAP[event] !== undefined) {
if (EVENT_MAP[event] !== undefined) {
Copy link
Contributor

@simonihmig simonihmig May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete the whole if-block here, as that does the special handling of these non-bubbling events, and only leave the else-block instead. The (now removed) MOUSE_ENTER_LEAVE_MOVE_EVENTS feature flag can effectively be seen as being always false, so in that way this if-block is basically dead code. Also the EVENT_MAP itself can be removed.

Copy link
Contributor Author

@btecu btecu May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simonihmig, I've removed the entire if block.

@btecu btecu force-pushed the mouse branch 3 times, most recently from 6a3a440 to 2b618a8 Compare May 25, 2021 00:16
@rwjblue
Copy link
Member

rwjblue commented May 27, 2021

Due to some complications with 3.27's migration to use real modules (and the resulting massive number of deprecations being triggered) we are not 100% certain (yet) that 4.0 will be the version just after v3.28.

In order to move ahead with v4.0 cleanup efforts (like this one), I've pushed a new branch that can serve as the target for breaking change PR's: https://github.com/emberjs/ember.js/tree/v4-cleanup.

I've updated this PR to target that branch, can you rebase against that branch and push an update?

Expand for an example of the commands needed for that rebase. 
# starting from this PR's branch

git fetch origin
git rebase origin/v4-cleanup

# fix any conflicts

# push the rebase
git push -f

Those steps should be roughly what you need, but might need some tweaks based on your local repository setup (e.g. if you don't use origin for the main emberjs/ember.js repo you might have to use another remote name there).

Thank you for helping us push things forward!

@rwjblue rwjblue changed the base branch from master to v4-cleanup May 27, 2021 15:00
@rwjblue rwjblue closed this Jul 18, 2021
@rwjblue rwjblue deleted the branch emberjs:v4-cleanup July 18, 2021 02:05
@mixonic
Copy link
Member

mixonic commented Jul 18, 2021

@btecu this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonihmig simonihmig simonihmig left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@btecu @rwjblue @mixonic @simonihmig