Skip to content

[CLEANUP] Remove Logger#19528

Merged
rwjblue merged 1 commit intoemberjs:v4-cleanupfrom
btecu:logger
May 27, 2021
Merged

[CLEANUP] Remove Logger#19528
rwjblue merged 1 commit intoemberjs:v4-cleanupfrom
btecu:logger

Conversation

@btecu
Copy link
Contributor

@btecu btecu commented May 3, 2021

No description provided.

@rwjblue
Copy link
Member

rwjblue commented May 27, 2021

Due to some complications with 3.27's migration to use real modules (and the resulting massive number of deprecations being triggered) we are not 100% certain (yet) that 4.0 will be the version just after v3.28.

In order to move ahead with v4.0 cleanup efforts (like this one), I've pushed a new branch that can serve as the target for breaking change PR's: https://github.com/emberjs/ember.js/tree/v4-cleanup.

I've updated this PR to target that branch, can you rebase against that branch and push an update?

Expand for an example of the commands needed for that rebase.
# starting from this PR's branch

git fetch origin
git rebase origin/v4-cleanup

# fix any conflicts

# push the rebase
git push -f

Those steps should be roughly what you need, but might need some tweaks based on your local repository setup (e.g. if you don't use origin for the main emberjs/ember.js repo you might have to use another remote name there).

Thank you for helping us push things forward!

@rwjblue rwjblue changed the base branch from master to v4-cleanup May 27, 2021 14:58
@rwjblue rwjblue merged commit 5c9eb65 into emberjs:v4-cleanup May 27, 2021
@mixonic mixonic mentioned this pull request Jul 18, 2021
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants