[Feature] added module-unification route and route-test blueprints#16663
Merged
rwjblue merged 1 commit intoemberjs:masterfrom May 21, 2018
Merged
[Feature] added module-unification route and route-test blueprints#16663rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
0919638 to
f05498c
Compare
Member
I don't believe that there currently is a way to pass the required environment variables through I think this approach is fine for now though |
GavinJoyce
reviewed
May 20, 2018
blueprints/route/index.js
Outdated
| let filesDirectory = 'files'; | ||
|
|
||
| if (isModuleUnificationProject(this.project)) { | ||
| filesDirectory = 'module-unification-files'; |
Member
There was a problem hiding this comment.
It looks likes the content for classic and MU is the same. Perhaps it's possible to use the existing files for both by using appropriate dynamic path parts?
f05498c to
f3c992e
Compare
GavinJoyce
approved these changes
May 21, 2018
Member
GavinJoyce
left a comment
There was a problem hiding this comment.
👍 this is great, thanks @kevinansfield!
Member
|
Thank you!! |
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ember-cli/ember-cli#7530
This PR adds initial support for
ember g route foofrom a module unification app.QUESTIONS:
app/router.jsfile tosrc/router.jsin the tests. Is this approach ok for the moment? I couldn't see a way to getemberNewto generate a MU-style app/addon structure