[Feature] module unification controller & controller-test blueprints#16656
Conversation
package-lock.json
Outdated
| @@ -0,0 +1,13015 @@ | |||
| { | |||
| import Controller from '@ember/controller'; | ||
|
|
||
| export default Controller.extend({ | ||
| }); |
There was a problem hiding this comment.
this looks like it has the same content as the existing https://github.com/dexturr/ember.js/blob/d23b14d99095c062693193e447b0ca578006e063/blueprints/controller/files/__root__/__path__/__name__.js. Perhaps we can use that for both and delete this file?
There was a problem hiding this comment.
Yep, was copying the pattern of components but this is unnecessary here. Have done this now 👍
| ); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
perhaps it would be good to add a test for a nested controller tests for addons and apps for both MU and classic? we seem to be missing those test cases
|
This is great! Nice one! I've added one final comment. Perhaps you might also squash down to a single commit when you can? |
Remove missed comment Remove packagelock.json Remove uneeded file are per PR comments Add tests for nested components
f6e6087 to
8caa131
Compare
|
@GavinJoyce Squashed and new tests added 👍 |
|
CI failure seems to be flakiness:
|
|
Am I able to rerun the build? I couldn't seem to find the option or do I need to make a whitespace commit? |
|
Yep, restarted! |
|
👍 great work @dexturr @kevinansfield 👏 |
Part of ember-cli/ember-cli#7530
Module unification blueprints for controller and controller-test files. This was pair programmed by @kevinansfield and I at the Ember London Project Night.
Many thanks to @GavinJoyce for showing us what to do and walking us through module unification.