Skip to content

[Bug] Type Tests are included in dist (canary) #19588

@stefanpenner

Description

@stefanpenner

🐞 Describe the Bug

@ember/-internals/runtime/type-tests/* are included in dist, which currently fails with:

Build Error (PackagerRunner) in ../../../../../../emberjs/ember.js/@ember/-internals/runtime/type-tests/core.test.js

Module not found: Error: Can't resolve '../types/core' in '$TMPDIR/embroider/9caab5/emberjs/ember.js/@ember/-internals/runtime/type-tests/core.test.js'

I would seem like we should not produce this file in dist, and the problem will go away (as deleting the file in question does the trick)

🔬 Minimal Reproduction

gh embroider-build/embroider
cd test-packages/macro-sample-addon
// build link ember.js master to this addon
yarn test:ember

<

😕 Actual Behavior

Build fails, as embroider attempts to do stuff with the type-tests

🤔 Expected Behavior

Embroider should not fail, as the type tests should most likely not be present in the output.

🌍 Environment

  • Ember: master
  • Node.js/npm: -
npm version
{
  'macro-sample-addon': '0.0.0',
  npm: '6.13.4',
  ares: '1.15.0',
  brotli: '1.0.7',
  cldr: '35.1',
  http_parser: '2.9.3',
  icu: '64.2',
  llhttp: '2.0.4',
  modules: '72',
  napi: '5',
  nghttp2: '1.40.0',
  node: '12.16.1',
  openssl: '1.1.1d',
  tz: '2019c',
  unicode: '12.1',
  uv: '1.34.0',
  v8: '7.8.279.23-node.31',
  zlib: '1.2.11'
}
  • OS: all
  • Browser: N/A

➕ Additional Context

I will explore a fix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions