Skip to content

jquery-integration optional feature prints a warning even when enabled #16849

@boris-petrov

Description

@boris-petrov

I've followed all the steps that are needed for enabling jQuery integration (I have the latest versions of @ember/jquery and @ember/optional-features installed and in package.json; have "jquery-integration": true in optional-features.json) but I still see a warning in the console when accessing originalEvent. I see the following check:

return EmberENV._JQUERY_INTEGRATION === true;

Which returns false in my case as EmberENV is:

{"FEATURES":{},"EXTEND_PROTOTYPES":false,"_APPLICATION_TEMPLATE_WRAPPER":false,"_TEMPLATE_ONLY_GLIMMER_COMPONENTS":true}

I think _JQUERY_INTEGRATION defaults to true and perhaps it is being removed from the hash because it has the same value? If this is so, the code above should be changed to:

return EmberENV._JQUERY_INTEGRATION !== false;

Am I missing something?

P.S. Ember 3.3.1 and latest Ember CLI.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions