Update broccoli-babel-transpiler to v8.0.0-beta.1#460
Merged
rwjblue merged 3 commits intoemberjs:masterfrom Oct 28, 2022
Merged
Update broccoli-babel-transpiler to v8.0.0-beta.1#460rwjblue merged 3 commits intoemberjs:masterfrom
broccoli-babel-transpiler to v8.0.0-beta.1#460rwjblue merged 3 commits intoemberjs:masterfrom
Conversation
08cd6f8 to
b0e0d87
Compare
Member
|
Is it expected that this releases in a beta version as well? |
Member
Author
|
Not 100% sure, but I would think so yes. |
Member
|
Sounds good to me. |
kellyselden
approved these changes
Oct 13, 2022
rwjblue
reviewed
Oct 21, 2022
Member
rwjblue
left a comment
There was a problem hiding this comment.
Just a couple of minor points here, but overall this LGTM
index.js
Outdated
| } else { | ||
| // legacy codepath | ||
| return Object.assign({}, this._buildBroccoliBabelTranspilerOptions(config), options); | ||
| return merge({}, this._buildBroccoliBabelTranspilerOptions(config), { babel: options }); |
Member
There was a problem hiding this comment.
Can we just do spread here (instead of pulling lodash.merge)
index.js
Outdated
| let description = `000${++count}`.slice(-3); | ||
| let postDebugTree = this._debugTree(inputTree, `${description}:input`); | ||
| let options = Object.assign({}, this._buildBroccoliBabelTranspilerOptions(config), this.buildBabelOptions('babel', config)); | ||
| let options = merge({}, this._buildBroccoliBabelTranspilerOptions(config), { babel: this.buildBabelOptions('babel', config) }); |
Member
There was a problem hiding this comment.
Same here, I'd like to avoid merge
b0e0d87 to
1460db8
Compare
rwjblue
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.