Update @ember/string detection to work on itself#260
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jan 18, 2019
locks:modules-blacklist-option
Merged
Update @ember/string detection to work on itself#260rwjblue merged 1 commit intoemberjs:masterfrom locks:modules-blacklist-option
@ember/string detection to work on itself#260rwjblue merged 1 commit intoemberjs:masterfrom
locks:modules-blacklist-option
Conversation
rwjblue
reviewed
Jan 15, 2019
Member
rwjblue
left a comment
There was a problem hiding this comment.
Hmmm. Isn't the fix needed here to actually tweak _emberStringDependencyPresent to be something like:
_emberStringDependencyPresent() {
if (this.project.name() === '@ember/string') {
return true;
}
let checker = new VersionChecker(this.parent).for('@ember/string', 'npm');
return checker.exists();
},
Contributor
Author
|
@rwjblue 🤦♂️ updated. |
@ember/string detection to check if it is the project being run
rwjblue
approved these changes
Jan 18, 2019
@ember/string detection to check if it is the project being run@ember/string detection to work on itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the tests for
@ember/string,ember-cli-babeldoes not detect it properly and tries to process the imports for that module, leading to a failed test run.