Skip to content

[cleanup]: Remove implicit store injection slated for Ember v4.0.0#7667

Merged
snewcomer merged 3 commits intomasterfrom
sn/rm-store-inject
Sep 30, 2021
Merged

[cleanup]: Remove implicit store injection slated for Ember v4.0.0#7667
snewcomer merged 3 commits intomasterfrom
sn/rm-store-inject

Conversation

@snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Aug 20, 2021 •
edited
Loading

Released as part of our 4.0 release series.

ref: emberjs/ember.js#19680

ref: emberjs/ember.js#19358

@github-actions
Copy link

github-actions bot commented Aug 20, 2021 •
edited
Loading

Asset Size Report for eee5792

IE11 Builds

✅ EmberData shrank by -133.0 B (-11.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +198.23 KB -133.0 B (+40.77 KB -11.0 B compressed)
    ember-data +9.36 KB -133.0 B (+1.92 KB -11.0 B compressed)
        ember-data/setup-container +387.0 B -133.0 B (+79.59 B -11.0 B compressed)
Full Asset Analysis (IE11) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '198.23 KB' │
│ compressed │ '40.77 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '81.83 KB' │
│  compressed  │ '16.83 KB' │
│ % Of Library │   '41.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 80.92 KB  | 16.64 KB   | 98.9          | 40.8
	@ember-data/store/index                           | 936.00 B  | 192.50 B   | 1.1           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.11 KB' │
│  compressed  │ '6.60 KB'  │
│ % Of Library │   '16.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 31.63 KB  | 6.51 KB    | 98.5          | 16.0
	@ember-data/model/index                           | 486.00 B  | 99.95 B    | 1.5           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.74 KB' │
│  compressed  │ '5.29 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.74 KB  | 5.29 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.13 KB' │
│  compressed  │ '4.35 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.84 KB   | 1.61 KB    | 37.1          | 4.0
	@ember-data/serializer/-private                   | 5.81 KB   | 1.19 KB    | 27.5          | 2.9
	@ember-data/serializer/json-api                   | 3.96 KB   | 833.57 B   | 18.7          | 2.0
	@ember-data/serializer/rest                       | 3.04 KB   | 641.27 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 273.00 B  | 56.14 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.21 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.93 KB' │
│  compressed  │ '3.69 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.23 KB   | 1.90 KB    | 51.5          | 4.7
	@ember-data/adapter/-private                      | 3.84 KB   | 808.69 B   | 21.4          | 1.9
	@ember-data/adapter/error                         | 1.98 KB   | 416.27 B   | 11.0          | 1.0
	@ember-data/adapter/index                         | 1.51 KB   | 318.16 B   | 8.4           | 0.8
	@ember-data/adapter/json-api                      | 1.37 KB   | 288.55 B   | 7.6           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.36 KB' │
│  compressed  │ '1.92 KB' │
│ % Of Library │   '4.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 508.82 B   | 25.8          | 1.2
	ember-data/-private                               | 2.12 KB   | 446.71 B   | 22.7          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 250.29 B   | 12.7          | 0.6
	ember-data/setup-container                        | 387.00 B  | 79.59 B    | 4.0           | 0.2
	ember-data/relationships                          | 318.00 B  | 65.40 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.35 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.62 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.38 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.97 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.97 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 49.56 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.74 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.71 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.48 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.65 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.65 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.83 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 33.11 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.07 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 654.85 B   | 44.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 334.62 B   | 22.5          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 104.06 B   | 7.0           | 0.2
	ember-inflector/index                             | 473.00 B  | 97.28 B    | 6.5           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 96.87 B    | 6.5           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 72.39 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 68.28 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.87 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.07 KB'  │
│  compressed  │ '646.21 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.58 KB   | 543.37 B   | 84.1          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 102.83 B   | 15.9          | 0.2

Modern Builds

✅ EmberData shrank by -133.0 B (-42.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +179.06 KB -133.0 B (+38.96 KB -42.0 B compressed)
    ember-data +9.36 KB -133.0 B (+2.04 KB -42.0 B compressed)
        ember-data/setup-container +387.0 B -133.0 B (+84.2 B -42.0 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.06 KB' │
│ compressed │ '38.96 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.24 KB' │
│  compressed  │ '15.72 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.32 KB  | 15.52 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 203.65 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.56 KB' │
│  compressed  │ '6.21 KB'  │
│ % Of Library │   '15.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.08 KB  | 6.11 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.74 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.77 KB' │
│  compressed  │ '5.17 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.77 KB  | 5.17 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.19 KB    | 27.9          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 830.28 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 615.31 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.13 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.77 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.98 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.13 KB   | 1.77 KB    | 50.8          | 4.5
	@ember-data/adapter/-private                      | 3.77 KB   | 840.29 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 432.76 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.77 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 232.37 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.36 KB' │
│  compressed  │ '2.04 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 538.29 B   | 25.8          | 1.3
	ember-data/-private                               | 2.12 KB   | 472.58 B   | 22.7          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.79 B   | 12.7          | 0.7
	ember-data/setup-container                        | 387.00 B  | 84.20 B    | 4.0           | 0.2
	ember-data/relationships                          | 318.00 B  | 69.19 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.61 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.61 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.30 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.87 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.87 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.43 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.56 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.47 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.17 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.30 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.30 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.43 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 35.03 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 641.63 B   | 43.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.99 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.91 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.47 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.15 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.58 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.18 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.40 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '625.75 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 517.17 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.57 B   | 17.4          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -133.0 B (-80.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +220.66 KB -133.0 B (+42.35 KB -80.0 B compressed)
    ember-data +9.52 KB -133.0 B (+1.83 KB -80.0 B compressed)
        ember-data/setup-container +387.0 B -133.0 B (+74.27 B -80.0 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.66 KB' │
│ compressed │ '42.35 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.93 KB' │
│  compressed  │ '18.80 KB' │
│ % Of Library │   '44.4'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.37 KB  | 3.33 KB    | 17.7          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.45 KB  | 2.77 KB    | 14.8          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.09 KB   | 1000.67 B  | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 898.95 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 822.76 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.98 KB   | 782.65 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 701.46 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 669.41 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 610.11 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.82 KB   | 554.84 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 448.32 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.96 KB   | 385.37 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.59 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.12 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 297.28 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 259.86 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 258.90 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 224.16 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 206.89 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 982.00 B  | 188.46 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 967.00 B  | 185.58 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.63 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.25 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.04 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 798.00 B  | 153.15 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.51 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.76 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.38 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 116.49 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.76 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.14 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.19 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.46 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.36 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.76 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.42 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.84 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.75 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.64 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.65 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.62 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.32 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.22 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.68 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.30 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.43 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.05 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.85 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.85 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.85 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.89 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.70 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.70 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.93 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.93 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.17 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.59 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.02 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.02 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.67 KB' │
│  compressed  │ '6.27 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.20 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 747.52 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 560.02 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 409.55 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.43 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 246.23 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.47 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.17 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 131.84 B   | 2.1           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.36 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.27 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.78 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.82 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.06 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 431.00 B  | 82.71 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.84 KB' │
│  compressed  │ '5.92 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.21 KB   | 1.58 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 954.99 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 617.02 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.83 KB   | 555.99 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 394.97 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 377.89 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.36 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.31 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.62 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.50 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.23 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.80 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.01 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.91 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.23 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.67 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.81 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.78 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.38 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 862.29 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 732.36 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 542.74 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.22 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.37 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.30 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.59 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.62 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.15 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.51 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.32 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.26 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.11 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.13 KB   | 1.56 KB    | 44.9          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 381.72 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 380.00 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 215.90 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 204.97 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.66 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.00 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.62 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.12 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.13 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.59 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.60 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.21 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.52 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 474.80 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 378.84 B   | 20.2          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.56 B   | 12.5          | 0.5
	ember-data/setup-container                        | 387.00 B  | 74.27 B    | 4.0           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.24 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.03 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.58 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.17 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.02 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.63 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.63 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.25 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.48 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.52 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.37 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.60 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.60 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.83 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.89 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 565.97 B   | 43.0          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.25 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.77 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.39 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.58 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.55 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.03 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.80 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '551.96 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.19 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.76 B    | 17.4          | 0.2

@snewcomer snewcomer self-assigned this Aug 20, 2021
@snewcomer snewcomer added 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ deprecation 🎯 canary PR is targeting canary (default) labels Aug 20, 2021
@snewcomer snewcomer mentioned this pull request Sep 12, 2021
Merged
@snewcomer snewcomer changed the title Remove implicit store injection slated for Ember v4.0.0 [cleanup]: Remove implicit store injection slated for Ember v4.0.0 Sep 19, 2021
@snewcomer snewcomer requested review from igorT and rwjblue September 19, 2021 12:50
@github-actions
Copy link

github-actions bot commented Sep 30, 2021

Performance Report for eee5792

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-2ms to 35ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-20ms to 6ms]
⚠️ Phase [start-find-all] => [start-materialization]
phase estimated regression +23ms [6ms to 40ms] OR +2.16% [0.52% to 3.73%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-4ms to 6ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-2ms to 5ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-24ms to 16ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 7ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-18ms to 12ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-3ms to 4ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-11ms to 33ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 7ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-7ms to 23ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 12ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 19ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-9ms to 14ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-4ms to 8ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 15ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-11ms to 6ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-14ms to 12ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 3ms]

@snewcomer snewcomer merged commit e973920 into master Sep 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the sn/rm-store-inject branch September 30, 2021 01:11
chancancode added a commit to ember-learn/super-rentals-tutorial that referenced this pull request Oct 29, 2021
@chancancode
Use ember-data@4.1.0-alpha while waiting for backport
2c04c83 
warp-drive-data/warp-drive#7667

This is currently causing the build to fail since without this
patch it triggers the ember implicit injection deprecation.
@chancancode chancancode mentioned this pull request Oct 29, 2021
Closed
chancancode added a commit to ember-learn/super-rentals-tutorial that referenced this pull request Oct 29, 2021
@chancancode
Use ember-data@4.1.0-alpha while waiting for backport
67df1da 
warp-drive-data/warp-drive#7667

This is currently causing the build to fail since without this
patch it triggers the ember implicit injection deprecation.
chancancode added a commit to ember-learn/super-rentals-tutorial that referenced this pull request Oct 29, 2021
@chancancode
Use ember-data@4.1.0-alpha while waiting for backport
8649180 
warp-drive-data/warp-drive#7667

This is currently causing the build to fail since without this
patch it triggers the ember implicit injection deprecation.
chancancode added a commit to ember-learn/super-rentals-tutorial that referenced this pull request Oct 29, 2021
@chancancode
Use ember-data@4.1.0-alpha while waiting for backport
d8f1369 
warp-drive-data/warp-drive#7667

This is currently causing the build to fail since without this
patch it triggers the ember implicit injection deprecation.
chancancode added a commit to ember-learn/super-rentals-tutorial that referenced this pull request Oct 30, 2021
@chancancode
Use ember-data@4.1.0-alpha while waiting for backport
6e4e73a 
warp-drive-data/warp-drive#7667

This is currently causing the build to fail since without this
patch it triggers the ember implicit injection deprecation.
igorT pushed a commit that referenced this pull request Nov 3, 2021
@snewcomer
[cleanup]: Remove implicit store injection slated for Ember v4.0.0 (#…
a3e882d 
…7667)
@igorT igorT mentioned this pull request Nov 3, 2021
Merged
igorT added a commit that referenced this pull request Nov 4, 2021
@igorT @snewcomer
[cleanup]: Remove implicit store injection slated for Ember v4.0.0 (#… (
c178c64 
#7736)

* [cleanup]: Remove implicit store injection slated for Ember v4.0.0 (#7667)

* CI timeouts testing bump (#7734)

Co-authored-by: Scott Newcomer <snewcomer@users.noreply.github.com>
@jrjohnson jrjohnson mentioned this pull request Nov 8, 2021
Merged
@snewcomer snewcomer mentioned this pull request Nov 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

1 more reviewer

@igorT igorT igorT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@snewcomer snewcomer

Labels

🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ deprecation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@snewcomer @igorT