Skip to content

[Feature] added module-unification adapter and adapter-test blueprints#5476

Merged
rwjblue merged 1 commit intowarp-drive-data:masterfrom
kevinansfield:mu-adapter-blueprint
Jun 11, 2018
Merged

[Feature] added module-unification adapter and adapter-test blueprints#5476
rwjblue merged 1 commit intowarp-drive-data:masterfrom
kevinansfield:mu-adapter-blueprint

Conversation

@kevinansfield
Copy link
Copy Markdown
Contributor

@kevinansfield kevinansfield commented May 23, 2018

Part of ember-cli/ember-cli#7530

This PR adds initial support for ember g adapter foo from a module unification app.

@GavinJoyce
Copy link
Copy Markdown

GavinJoyce commented Jun 5, 2018

@kevinansfield do you think the CI failure is just flakiness or is it something to address?

@kevinansfield
Copy link
Copy Markdown
Contributor Author

kevinansfield commented Jun 5, 2018

@GavinJoyce just flakiness I think? The error is from installing yarn before the tests even start:

$ yarn --version
1.3.2
$ curl -o- -L https://yarnpkg.com/install.sh | bash
bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'
(23) Failed writing body

I'm guessing yarnpkg.com errored?

@GavinJoyce GavinJoyce mentioned this pull request Jun 6, 2018
Closed
29 tasks
@GavinJoyce
Copy link
Copy Markdown

GavinJoyce commented Jun 7, 2018

@kevinansfield perhaps rebase and force push to kick off CI again?

@kevinansfield kevinansfield force-pushed the mu-adapter-blueprint branch from e85c861 to 201f35a Compare June 8, 2018 07:13
@kevinansfield
Copy link
Copy Markdown
Contributor Author

kevinansfield commented Jun 8, 2018

👍 done

GavinJoyce
GavinJoyce approved these changes Jun 11, 2018
View reviewed changes
Copy link
Copy Markdown

@GavinJoyce GavinJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @kevinansfield, sorry for the delay in reviewing.

This looks good to me. /cc @rwjblue

@rwjblue rwjblue merged commit e195cb4 into warp-drive-data:master Jun 11, 2018
@rwjblue
Copy link
Copy Markdown
Contributor

rwjblue commented Jun 11, 2018

Thank you @kevinansfield (and @GavinJoyce for reviewing)!

@dcyriller dcyriller mentioned this pull request Jun 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GavinJoyce GavinJoyce GavinJoyce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinansfield @GavinJoyce @rwjblue