Skip to content

Removes Ember.K from codebase#4670

Merged
stefanpenner merged 1 commit intomasterfrom
remove-ember-k
Nov 20, 2016
Merged

Removes Ember.K from codebase#4670
stefanpenner merged 1 commit intomasterfrom
remove-ember-k

Conversation

@locks
Copy link
Copy Markdown
Contributor

@locks locks commented Nov 20, 2016

No description provided.

@locks locks force-pushed the remove-ember-k branch 2 times, most recently from 34225a5 to 1dc7198 Compare November 20, 2016 01:35
@stefanpenner stefanpenner merged commit fdf56b7 into master Nov 20, 2016
@stefanpenner stefanpenner deleted the remove-ember-k branch November 20, 2016 02:30
sduquej added a commit to sduquej/data that referenced this pull request Nov 20, 2016
Copy link
Copy Markdown
Contributor

@cibernox cibernox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -1,4 +1,4 @@
/*eslint no-unused-vars: ["error", { "varsIgnorePattern": "(adam|dave|cersei)" }]*/
3/*eslint no-unused-vars: ["error", { "varsIgnorePattern": "(adam|dave|cersei)" }]*/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but there is a number here 👀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had actually fixed this and "pushed", but I forgot to actually git add the file so it was in the commit… Thanks @sduquej :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 It was also a bit too late when I saw it. @locks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants