allow direct access to browser and node implementations#8
Merged
Conversation
By default, consumers will get either the node or browser implementation automatically based on their environment. Since these implementations support slightly different options, consumers that want to be portable themselves may want to pick one implementation (probably the browser one, since it is the more portable) and stick to it, regardless of their own environment. This change enables that by allowing direct imports of `babel-plugin-ember-template-compilation/browser` and `babel-plugin-ember-template-compilation/node`, both of which bypass the automatic environment switching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, consumers will get either the node or browser implementation automatically based on their environment.
Since these implementations support slightly different options, consumers that want to be portable themselves may want to pick one implementation (probably the browser one, since it is the more portable) and stick to it, regardless of their own environment.
This change enables that by allowing direct imports of
babel-plugin-ember-template-compilation/browserandbabel-plugin-ember-template-compilation/node, both of which bypass the automatic environment switching.