Skip to content

Deprecate modifier() without { eager: false }#223

Merged
chriskrycho merged 1 commit intomasterfrom
deprecate-eager
Mar 25, 2022
Merged

Deprecate modifier() without { eager: false }#223
chriskrycho merged 1 commit intomasterfrom
deprecate-eager

Conversation

@chriskrycho
Copy link
Copy Markdown
Contributor

This assumes, and should land immediately after, #222.

@chriskrycho chriskrycho mentioned this pull request Mar 24, 2022
19 tasks
@chriskrycho chriskrycho force-pushed the deprecate-eager branch 6 times, most recently from 93d9285 to 753804f Compare March 24, 2022 23:20
Copy link
Copy Markdown
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. One minor inline comment, and I think it needs a rebase/merge/etc to drop out the commits from #222.

@chriskrycho chriskrycho requested a review from rwjblue March 25, 2022 21:30
@chriskrycho chriskrycho merged commit aeb8c1f into master Mar 25, 2022
@chriskrycho chriskrycho deleted the deprecate-eager branch March 25, 2022 22:41
@beerinho
Copy link
Copy Markdown

Hey @chriskrycho, what is the plan to update the docs with the changes in this PR? I updated ember-modifier yesterday to 3.2.0 and am getting the deprecation about not passing options, I feel like I have updated my modifier to pass in {eager: false} but I still get the deprecation warning and I couldn't find anything in the docs to help me figure out where I'm going wrong. My modifier looks like this:

  return modifier(
    function suggestModifier(element, [function_, ...args], named) {
        ...function code
    },
    { eager: false }
  );

@chriskrycho
Copy link
Copy Markdown
Contributor Author

The docs are updated! Additionally there is an entire migration guide. That said, I’m sorry you’re having this issue; please open an issue with a more detailed report so we can help you get to the bottom of it (and possibly fix the deprecation if it’s firing when it shouldn’t be).

@chriskrycho
Copy link
Copy Markdown
Contributor Author

I believe this is probably #249. I'll have a fix out for it in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants