Deprecate modifier() without { eager: false }#223
Conversation
93d9285 to
753804f
Compare
753804f to
4cf48b2
Compare
|
Hey @chriskrycho, what is the plan to update the docs with the changes in this PR? I updated ember-modifier yesterday to 3.2.0 and am getting the deprecation about not passing options, I feel like I have updated my modifier to pass in |
|
The docs are updated! Additionally there is an entire migration guide. That said, I’m sorry you’re having this issue; please open an issue with a more detailed report so we can help you get to the bottom of it (and possibly fix the deprecation if it’s firing when it shouldn’t be). |
|
I believe this is probably #249. I'll have a fix out for it in a while. |
This assumes, and should land immediately after, #222.