Skip to content

Fixes import on test example#811

Merged
locks merged 2 commits intoember-learn:masterfrom
villander:master
May 30, 2019
Merged

Fixes import on test example#811
locks merged 2 commits intoember-learn:masterfrom
villander:master

Conversation

@villander
Copy link
Copy Markdown
Contributor

this fixes #774

@villander
Copy link
Copy Markdown
Contributor Author

cc @jenweber

Copy link
Copy Markdown
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to come up with an app name, put it in the text, and then use it in the import. People tend to take code samples very literally when reading documentation!

@jenweber
Copy link
Copy Markdown
Contributor

I think my-app-name could work well here. I'll add a comment showing it in action.

Co-Authored-By: Jen Weber <weberj10@gmail.com>
@locks locks merged commit d136674 into ember-learn:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is the first unit tests example correct?

3 participants