👋 Replacing willTransition with routeWillChange here isn't correct as Routes do not have the routeWillChange event. routeWillChange is an event on the RouterService.

Maybe it's a good idea to reuse that example here as well?

• It uses constructor instead of init
• It doesn't access the controller (accessing the controller outside of the setupController and resetController hooks is linted against)

The action import can be omitted though, it isn't used. I made a PR here to address this.

I think some of the copy around the code examples needs updating as well. For instance:

When a transition is attempted, whether via <LinkTo />, transitionTo, or a URL change, a willTransition action is fired on the currently active routes.

Could be updated to something like:

When a transition is attempted, whether via <LinkTo />, transitionTo, or a URL change, a routeWillChange event is fired on the RouterService.

Could be that some of the other copy needs a bit of updating as well.

Hi, thanks for your PR! I will review it this week. If anyone else has time to review sooner, please go for it. I need a little time to test the example in an app.

Percy is failing for some strange reason 🙈 I know what the issue is: the problem is that we have changed the browser since our last build on master 🙃

After we merge this the master will build again, and future PRs will be happy 🎉