migrate test-helpers.js to import APP from src/main#73
Merged
rwjblue merged 1 commit intoember-codemods:masterfrom Apr 13, 2018
Merged
migrate test-helpers.js to import APP from src/main#73rwjblue merged 1 commit intoember-codemods:masterfrom
rwjblue merged 1 commit intoember-codemods:masterfrom
Conversation
22 tasks
rwjblue
approved these changes
Apr 13, 2018
Member
|
Thank you @iezer ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate test-helpers.js to import APP from src/main. This means we can remove the manual step from the README.
Fixes the 1st migrator bullet in emberjs/ember.js#16373
There's a separate but similar fixture called
test-helperswhich I left unchanged. That test has astart-app.jsfile so it's for apps that haven't migrating to the new testing structure. This new test has nostart-app.jsand thus the App import is done intest-helper.js.