Fetch dynamically the ember-source version for MU blueprints#8323
Merged
rwjblue merged 2 commits intoember-cli:masterfrom Jan 2, 2019
Merged
Fetch dynamically the ember-source version for MU blueprints#8323rwjblue merged 2 commits intoember-cli:masterfrom
ember-source version for MU blueprints#8323rwjblue merged 2 commits intoember-cli:masterfrom
Conversation
Member
Totally agree. |
rwjblue
reviewed
Dec 29, 2018
Move the logic from the `addonBlueprint` to the `muAddonBlueprint because the `addonBlueprint` does not need to include this feature
rwjblue
approved these changes
Jan 2, 2019
ember-source version for MU blueprintsember-source version for MU blueprints
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #8317.
With this change, we won't have to set manually the ember-source version in the blueprint and test fixtures, and it will always select the latest Canary build.
cc @rwjblue
Additionally, it could be good if we improve the procedure to upgrade the Ember and Ember Data versions (see this commit).
We could define a top level variable to be reused in the blueprint and test fixtures, in a similar way than the
<%= emberCLIVersion %>.Thoughts?