Reset blueprint's ignoredFiles#8240
Reset blueprint's ignoredFiles#8240kellyselden merged 3 commits intoember-cli:releasefrom dcyriller:reset-ignoredFiles-blueprint
Conversation
kellyselden
left a comment
There was a problem hiding this comment.
Looks good to me, but I'm hesitant to merge something like this without a regression test. Can you find a place to add one?
|
I've inserted a commit to highlight the bug. The second commit is the fix. I'm going to add a third commit to actually prevent regression with a test. |
|
@kellyselden I added a test. I ended up with: a first commit for the failing test, a second commit for the fix. |
|
@dcyriller Some tests are failing, try running the tests with the MU flag:
|
|
Thank you @ppcano, it's fixed now |
|
I have tested this PR, and I confirm this will fix the emberjs/ember.js#17212 test errors |
|
ping @kellyselden |
|
Can you rebase one more time? We fixed the remaining AppVeyor issues so it should go green. |
When running `ember new` or `ember addon` in sequence, on the same node
process, `ignoredFiles` gets properly incremented. But it's never reset.
This change is especially usefull in tests.
This PR aims at reseting the key so that the following test setup
works properly:
```javascript
beforeEach(() => {
emberNew({ isModuleUnification: true, target: 'addon' })
})
```
The bug occured while testing the `addon` blueprint for the Module
Unification Quest. Because in the tests, we want to make sure the `src`
directory exists. Previously, `addon` directory was disapearing but
the issue remained silent as we were not asserting its existence.
|
Great. I rebased, CI is running. |
|
Thanks for working on this! |
|
emberjs/ember.js#17253 finally upgraded Ember to But this fix is needed if we want to remove unnecessary call to |
|
Restarted AppVeyor, all green now. |
When running
ember neworember addonin sequence, on the same nodeprocess,
ignoredFilesgets properly incremented. But it was never reset.The change this PR introduce is especially usefull in tests.
This PR aims at reseting the key so that the following test setup
works properly:
Indeed, a bug occured while testing the
addonblueprint for the ModuleUnification Quest. Because in the tests, we want to make sure the
srcdirectory exists. Previously,
addondirectory was disapearing butthe issue remained silent as we were not asserting its existence.
I set the release branch as a target. Because this would unblock
ember-cliupgrade in emberjs package (emberjs/ember.js#17212). Not sure if it's appropriate though./cc @ppcano