New command respects module unification experiment#7869
Merged
rwjblue merged 4 commits intoember-cli:masterfrom Jun 10, 2018
Merged
New command respects module unification experiment#7869rwjblue merged 4 commits intoember-cli:masterfrom
New command respects module unification experiment#7869rwjblue merged 4 commits intoember-cli:masterfrom
Conversation
New command respects module unification experiment
* Make confirmBlueprinted app specific and MU aware in acceptance/new * Guard or skip for other failing tests when is MU enabled
rwjblue
reviewed
Jun 10, 2018
|
|
||
| if (experiments.MODULE_UNIFICATION) { | ||
| describe('Acceptance: addon-mu-smoke-test', function() { | ||
| describe.skip('Acceptance: addon-mu-smoke-test', function() { |
Member
There was a problem hiding this comment.
just pointing out, this .skip will need to be removed before landing
Contributor
Author
There was a problem hiding this comment.
I'm not sure what to do about this. It seems that addon-mu-smoke-test-slow fails for MU. Prior to this PR, MODULE_UNIFICATION env was never set, so the new command in createTestTargets would actually generate a classic app. Outside of skipping, I can either comment it out or just remove it completely?
Member
There was a problem hiding this comment.
OK, I see. Thank you for explaining! Can you create an issue (cross-linking this comment thread and linking to this describe.skip) so we can track fixing that separately?
New command respects module unification experimentNew command respects module unification experiment
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for specifying the additional
MODULE_UNIFICATIONenv for thenewcommand by respecting the new Experiments feature toggling.It also exposes gaps in MU testing and some needed fixture verification.
(Thank you @mixonic for your help today.)