Skip to content

remove config caching#7739

Merged
rwjblue merged 1 commit intoember-cli:masterfrom
GavinJoyce:gj/remove-config-caching
Apr 5, 2018
Merged

remove config caching#7739
rwjblue merged 1 commit intoember-cli:masterfrom
GavinJoyce:gj/remove-config-caching

Conversation

@GavinJoyce
Copy link
Copy Markdown
Contributor

@GavinJoyce GavinJoyce commented Apr 5, 2018

Config caching was added as part of #7491, but it resulted in a bunch of blueprint test failures for tests in ember-source, see this discussion.

Removing this will unblock the MU blueprint work.

@GavinJoyce GavinJoyce force-pushed the gj/remove-config-caching branch from 7f63246 to 4226f84 Compare April 5, 2018 18:57
Copy link
Copy Markdown
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, though I think you will have a linting error due to let config; on line 3 (which is unused)..

Looks great!

@rwjblue rwjblue merged commit 8f5a13a into ember-cli:master Apr 5, 2018
@GavinJoyce GavinJoyce deleted the gj/remove-config-caching branch April 5, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants