Don't run addon-import blueprint if project.isModuleUnification()#7702
Merged
mixonic merged 1 commit intoember-cli:masterfrom Apr 1, 2018
Merged
Don't run addon-import blueprint if project.isModuleUnification()#7702mixonic merged 1 commit intoember-cli:masterfrom
addon-import blueprint if project.isModuleUnification()#7702mixonic merged 1 commit intoember-cli:masterfrom
Conversation
3 tasks
project.isModuleUnification()addon-import blueprint if project.isModuleUnification()
eb32963 to
5c54d87
Compare
addon-import blueprint if project.isModuleUnification()addon-import blueprint if project.isModuleUnification()
5c54d87 to
bb983ab
Compare
addon-import blueprint if project.isModuleUnification()addon-import blueprint if project.isModuleUnification()
bb983ab to
65cdf47
Compare
addon-import blueprint if project.isModuleUnification()addon-import blueprint if project.isModuleUnification()
Contributor
Author
|
This is ready for review |
Member
|
@GavinJoyce I kicked a build here but I'm not sure why it is failing. Doesn't seem related. Your change here makes sense to me, and I chatted it over with @Turbo87 as well. |
65cdf47 to
7b6be06
Compare
Contributor
Author
|
now 🍏 after a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for emberjs/ember.js#16397 (comment). Module unification addons don't have an
/apppath. This PR prevents the defaultaddon-importblueprint from running whenproject.isModuleUnification() === true.TODO:
CI failures look unrelated: #7716