Closed
Conversation
5b54ec3 to
fd63b41
Compare
kategengler
reviewed
May 10, 2023
- In TS, add an `import 'ember-source/types'` statement. - In JS, add a `/** @typedef {import('ember-source/types')} */` comment.
fd63b41 to
e95e918
Compare
Member
|
I'm not positive on where to test it (I'm somewhat surprised nothing fails with this added). I'd think in https://github.com/ember-cli/ember-cli/blob/master/tests/acceptance/new-test.js and/or https://github.com/ember-cli/ember-cli/blob/master/tests/acceptance/init-test.js |
Member
|
Is this still relevant? |
Contributor
|
blocked on ember-data being compatible with the stable types |
Contributor
|
This can probably be closed since #10506 was merged. That didn't include the type import comment for js projects though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import 'ember-source/types'statement./** @typedef {import('ember-source/types')} */comment.This is sufficient to make the types shipped in Ember itself as of emberjs/ember.js#20449 "enabled" for end users out of the box. It should be coordinated with an
ember-cli-typescriptrelease which removes the@types/emberpackages from its own blueprint so that users do not get those installed needlessly.(Maintainers: what's the best spot to test this?)