add giga-embedding-instruct model#77
Closed
ekolodin wants to merge 4 commits into
Closed
Conversation
Member
|
Could you run |
7 tasks
KennethEnevoldsen
requested changes
Feb 5, 2025
Member
|
@KennethEnevoldsen I was trying to add this model in embeddings-benchmark/mteb#1741 |
Contributor
|
Ah yes I see - I could have seen that from the reference |
Contributor
|
Re-reviewed this PR. Seems like the revision is missing. I don't think we can merge it without it. However @Samoed's implementation has been merged so it should be easy to rerun. Will close this PR for now, but do open a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test.make pre-push.Adding a model checklist
Ref #
mteb/models/directory. Instruction to add a model can be found here