Ensure external does not have a revision#107
Merged
Merged
Conversation
generally we should not have external scores where the revision is specified (we have no garuantee that the scores are as specified)
Member
|
Can you update the load external script too? |
Contributor
Author
|
I think we should avoid using the |
Contributor
Author
|
Let me know if you agree I also added a few extra tests these should make the revision much more consistent in the future (they also disallow "external") essentially you are allowed to use a sha1 rev id or an integer (1, 2, 3) in case of APIs |
Contributor
Author
|
(@x-tabdeveloping just so that you see this) |
4 tasks
Member
|
Yes, I agree that with new leaderboard this script can be deleted |
Samoed
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External models had revision. This lead to duplicate scores (two results from the same model on the same revision).
I have replace the revision with "no_revision_available". I also think this more accurately reflects the reality (we don't know the version they used when they ran the model).
Checklist
make test.make pre-push.