[mieb] Fill in mocov3 and nomic vision model meta#1890
Merged
Conversation
isaac-chung
commented
Jan 28, 2025
| reference="https://huggingface.co/nomic-ai/nomic-embed-vision-v1.5", | ||
| similarity_fn_name=None, | ||
| use_instructions=None, | ||
| use_instructions=True, |
Collaborator
Author
There was a problem hiding this comment.
Does using a prefix like search query: mean use_instructions=True?
Member
There was a problem hiding this comment.
For now yes, but I don't like. I'll create issue for discussion
Samoed
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill in mocov3 and nomic vision model meta
Code Quality
make lintto maintain consistent style.Documentation
Testing
make test-with-coverage.make testormake test-with-coverageto ensure no existing functionality is broken.