Skip to content

[mieb] Fill in blip model meta#1874

Merged
isaac-chung merged 3 commits into
miebfrom
fill-in-blip-model-meta
Jan 26, 2025
Merged

[mieb] Fill in blip model meta#1874
isaac-chung merged 3 commits into
miebfrom
fill-in-blip-model-meta

Conversation

@isaac-chung

Copy link
Copy Markdown
Collaborator

Fill in BLIP and BLIP2 model meta.

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

@isaac-chung isaac-chung requested a review from Samoed January 26, 2025 14:25
Comment thread mteb/models/blip2_models.py Outdated
Comment on lines +267 to +271
training_datasets=[
# COCO
# CC3M+CC12M+SBU
# LAION400M
],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move to variable?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. Done.

@isaac-chung isaac-chung merged commit edaf0d6 into mieb Jan 26, 2025
@isaac-chung isaac-chung deleted the fill-in-blip-model-meta branch January 26, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants