Merged
Conversation
This is a breaking change.
Owner
|
OK, that makes sense, especially when reading the linked issue. Even https://github.com/fishinabarrel/linux-kernel-module-rust seems to opt for I hope the breaking change is not too painful :/ At least it's pre 1.0 ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
bindgenswitched the default output for parameters with thesize_tC type tou32/u64depending on the target platform. Per rust-lang/rust-bindgen#1671, the old behaviour wheresize_twould just outputusizeis not technically correct, because the C standard has a slightly different definition forsize_t.AFAIK it is correct for all platforms that Node.js supports though. bindgen added a toggle to opt back in to the old behaviour. Since bindgen had been doing this for years without issue, I think we're safe 🤔