Implement the GUI for auto date grouping#3
Merged
Conversation
elliotgnn
requested changes
Oct 19, 2025
elliotgnn
left a comment
Owner
There was a problem hiding this comment.
Great job, right now there are some issue when right click the group, error will pop up, suggest fix.
add import org.jabref.model.groups.AutomaticDateGroup;
add else if (group instanceof AutomaticDateGroup) { // <-- add this branch
return false; // date groups are computed, not manually assigned
}
add AutomaticDateGroup _,
add AutomaticDateGroup _,
add AutomaticDateGroup _,
add AutomaticDateGroup _,
This allows the adapting editing of group to automatic date group.
Also please fix the checks other then binaries
Collaborator
Author
|
Thank you! I have fixed the bugs and checks other than binaries. |
elliotgnn
approved these changes
Oct 23, 2025
elliotgnn
left a comment
Owner
There was a problem hiding this comment.
Great job on fixing tests and bugs! Looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented the GUI of Date group functionality as requested in JabRef#10822, allowing users to create automatic groups based on date fields with flexible granularity options.
Changes
GUI Implementation
getDateFields()method for date-related fieldsFeatures