Merged
Conversation
Contributor
There was a problem hiding this comment.
Hi @KONFeature! Welcome to the ai16z community. Thanks for submitting your first pull request; your efforts are helping us accelerate towards AGI. We'll review it shortly. You are now a ai16z contributor!
Member
|
looks good overall; needs testing |
wtfsayo
previously approved these changes
Jan 7, 2025
Member
wtfsayo
left a comment
There was a problem hiding this comment.
Updated .env.example, looks good, worked fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to
Issue: #1809
Risks
Low risk, if any would only impact dev env (since no one is running with an sqlite/pglite adapter in prod right?).
Background
What does this PR do?
Add a new db adapter for PGLite.
What kind of change is this?
Features
Why are we doing this? Any context or related work?
Faster dev env
Documentation changes needed?
My changes require a change to the project documentation, and I have updated the documentation accordingly.
For now I only specified added the new db adapter in the adapters section of the doc, and not replaced all the dev recommendation from SQLiteAdapter to PGLite.
Testing
Where should a reviewer start?
Check the diff between the
adapter-pgliteand theadapter-postgres.A few changes made but not super significative:
pglite.transaction(...)instead of manual pg txdb.querycallwithRetry), the circuitBreaker usage could also be removed, but I keeped it to reduce the amount of changes.Detailed testing steps
Multiple options:
packages/core/env.test, setTEST_DATABASE_CLIENT=pglitePGLITE_DATA_DIR=../pgLite/ # or "memory://" for in mem pgliteenv variable and ensure everything is running smoothlyconst db = new PGLiteAdapter(options)Discord username
konfeature