Skip to content

Align logger #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomas-consulting wants to merge 7 commits into from
Closed

Align logger #2610

thomas-consulting wants to merge 7 commits into from

Conversation

@thomas-consulting
Copy link

@thomas-consulting thomas-consulting commented Jul 31, 2014

Align the messages between log messages with different length level text. Added an extra format $levelpad, which is a space if the level is "warn" or "info".

So, basically

12:34:56.123 [info] a message from the logger
12:34:56.123 [error] a message from the logger
12:34:56.123 [debug] a message from the logger
12:34:56.123 [warn] a message from the logger

becomes

12:34:56.123 [info]  a message from the logger
12:34:56.123 [error] a message from the logger
12:34:56.123 [debug] a message from the logger
12:34:56.123 [warn]  a message from the logger

@josevalim
Copy link
Member

josevalim commented Jul 31, 2014

I would like to avoid this for now because my first reaction was to pad the levels to the right and honestly it is easier to just use a custom formatter so you can do whatever you want. :)

@josevalim josevalim closed this Jul 31, 2014
@thomas-consulting
Copy link
Author

thomas-consulting commented Jul 31, 2014

I think that's a shame. We've done a lot of work to make the output look
more readable. This is a really small thing that makes a big difference
when you scan logs (which I've been doing all day)
On Jul 31, 2014 2:05 AM, "José Valim" notifications@github.com wrote:

I would like to avoid this for now because my first reaction was to pad
the levels to the right and honestly it is easier to just use a custom
formatter so you can do whatever you want. :)

—
Reply to this email directly or view it on GitHub
#2610 (comment).

@nallwhy nallwhy mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomas-consulting @josevalim @pragdave