Skip to content

feat(progress-animation): Progress animation layer #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
melodicore merged 8 commits into from
Oct 22, 2025
Merged

feat(progress-animation): Progress animation layer #1708

melodicore merged 8 commits into from
Oct 22, 2025

Conversation

@melodicore
Copy link
Member

@melodicore melodicore commented Oct 21, 2025 •
edited by pull-request-badge bot
Loading

Ready for review Powered by Pull Request Badge

Summary

A progress animation layer that prints an animation to the console representing the progress of a process with multiple tasks.

@melodicore
feat(progress-animation): progress animation layer
a362eee 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore melodicore requested a review from sgammon as a code owner October 21, 2025 10:09
@melodicore melodicore added enhancement New feature or request feature Large PRs or issues with full-blown features labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.35135% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.36%. Comparing base (08f1ba5) to head (dd2abc9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../kotlin/elide/tool/cli/progress/ProgressManager.kt 14.28% 6 Missing ⚠️
...lide/tool/cli/progress/impl/ProgressManagerImpl.kt 90.19% 0 Missing and 5 partials ⚠️
...kotlin/elide/tool/cli/progress/ProgressRenderer.kt 96.92% 0 Missing and 2 partials ⚠️
...otlin/elide/tool/cli/progress/impl/ProgressImpl.kt 92.59% 2 Missing ⚠️
...rc/main/kotlin/elide/tool/cli/progress/Progress.kt 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
+ Coverage   40.13%   40.36%   +0.23%     
==========================================
  Files         874      883       +9     
  Lines       40708    40893     +185     
  Branches     5644     5662      +18     
==========================================
+ Hits        16338    16507     +169     
- Misses      22440    22449       +9     
- Partials     1930     1937       +7
Flag Coverage Δ
jvm 40.36% <91.35%> (+0.23%) ⬆️
lib 40.36% <91.35%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/kotlin/elide/tool/cli/progress/ProgressState.kt 100.00% <100.00%> (ø)
...c/main/kotlin/elide/tool/cli/progress/TaskEvent.kt 100.00% <100.00%> (ø)
...c/main/kotlin/elide/tool/cli/progress/TaskState.kt 100.00% <100.00%> (ø)
...main/kotlin/elide/tool/cli/progress/TrackedTask.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/elide/tool/cli/progress/Progress.kt 75.00% <75.00%> (ø)
...kotlin/elide/tool/cli/progress/ProgressRenderer.kt 96.92% <96.92%> (ø)
...otlin/elide/tool/cli/progress/impl/ProgressImpl.kt 92.59% <92.59%> (ø)
...lide/tool/cli/progress/impl/ProgressManagerImpl.kt 90.19% <90.19%> (ø)
.../kotlin/elide/tool/cli/progress/ProgressManager.kt 14.28% <14.28%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f1ba5...dd2abc9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@melodicore melodicore added the 🚧 WIP Works-in-progress. Blocks merge label Oct 21, 2025
@melodicore
feat(progress-animation): utilize flows better
3375fd7 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore
chore(progress-animation): api pins
02b36c2 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore melodicore removed the 🚧 WIP Works-in-progress. Blocks merge label Oct 22, 2025
darvld
darvld requested changes Oct 22, 2025
View reviewed changes
Copy link
Member

@darvld darvld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I'm requesting some minor changes for maintainability but otherwise it's ready. One more thing: the whole progress UI feature could be moved to the cli package, since it's unlikely to be used outside of it, let me know if you need help picking a specific location for it.

Props for adding actual UI tests for the terminal too.

@melodicore
fix(progress-animation): code review requested changes
d9db1fd 
Signed-off-by: melodicore <datafox@datafox.me>
darvld
darvld approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@darvld darvld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I'm approving ahead of the re-packaging, merge away when ready

@melodicore
chore(progress-animation): refactor into cli package
d267b63 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore
fix(progress-animation): fix test race condition
53b9761 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore
fix(progress-animation): fix test race condition again
3e9feed 
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore
fix(progress-animation): rollback previous changes, do tests with cor…
dd2abc9 
…outines properly

Signed-off-by: melodicore <datafox@datafox.me>
@melodicore melodicore merged commit cd30fef into main Oct 22, 2025
15 of 16 checks passed
@sgammon sgammon mentioned this pull request Oct 30, 2025
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgammon sgammon sgammon approved these changes

@darvld darvld darvld approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request feature Large PRs or issues with full-blown features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@melodicore @sgammon @darvld