Skip to content

fix: kotlinc/native-image bugs #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 4 commits into from
Oct 8, 2025
Merged

fix: kotlinc/native-image bugs #1690

sgammon merged 4 commits into from
Oct 8, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Oct 8, 2025 •
edited by pull-request-badge bot
Loading

sgammon added 4 commits October 7, 2025 18:57
@sgammon
fix(graalvm-kt): register all kotlinc flags for reflection
9235023 
Fixes: #1686
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix(graalvm-kt): only include extant paths as sources
c57fbcd 
Fixes: #1689
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix(graalvm-kt): embed class bytecode from kotlin stdlib/runtime
3f17619 
Fixes: #1688
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix(cli): recognize -o argument for native-image as outpath
8ec657b 
Fixes: #1687
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added this to the Release R18: Beta milestone Oct 8, 2025
@sgammon sgammon requested review from a team and Copilot October 8, 2025 02:19
@sgammon sgammon self-assigned this Oct 8, 2025
@sgammon sgammon requested review from natehak and removed request for natehak October 8, 2025 02:19
@sgammon sgammon added this to Elide Oct 8, 2025
@sgammon sgammon added bug Something isn't working lang:java Issues relating to Java language support lang:kotlin Related to Kotlin lang support labels Oct 8, 2025
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several issues discovered in elide kotlinc and elide native-image commands by improving metadata configuration and argument handling.

  • Updates reachability metadata for Kotlin CLI tools to use broader method and constructor reflection
  • Enhances native-image output path detection to support both -H:Path and -o flags
  • Adds source file existence filtering to the Java compiler tool

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
reachability-metadata.json Simplifies Kotlin CLI reflection metadata and adds Kotlin class resources
NativeImageAdapter.kt Improves output path argument detection for native-image
JavaCompiler.kt Adds file existence check for Java source files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sgammon sgammon changed the title Fix/kotlinc issues beta9 fix: kotlinc/native-image bugs Oct 8, 2025
@sgammon sgammon moved this to In Progress in Elide Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.26%. Comparing base (b16a10e) to head (8ec657b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ool/cli/cmd/tool/nativeImage/NativeImageAdapter.kt 0.00% 4 Missing ⚠️
.../src/main/kotlin/elide/tooling/jvm/JavaCompiler.kt 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1690   +/-   ##
=======================================
  Coverage   40.25%   40.26%           
=======================================
  Files         820      820           
  Lines       38603    38608    +5     
  Branches     5522     5523    +1     
=======================================
+ Hits        15541    15544    +3     
- Misses      21200    21201    +1     
- Partials     1862     1863    +1
Flag Coverage Δ
jvm 40.26% <0.00%> (+<0.01%) ⬆️
lib 40.26% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/main/kotlin/elide/tooling/jvm/JavaCompiler.kt 0.00% <0.00%> (ø)
...ool/cli/cmd/tool/nativeImage/NativeImageAdapter.kt 1.92% <0.00%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16a10e...8ec657b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit cac7c1f into main Oct 8, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Oct 8, 2025
@sgammon sgammon mentioned this pull request Oct 30, 2025
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

bug Something isn't working lang:java Issues relating to Java language support lang:kotlin Related to Kotlin lang support

Projects

Elide
Status: Done

Milestone

Release R18: Beta

3 participants

@sgammon @darvld