Skip to content

chore: upgrade → jdk25 #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 1 commit into from
Sep 26, 2025
Merged

chore: upgrade → jdk25 #1669

sgammon merged 1 commit into from
Sep 26, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Sep 25, 2025 •
edited
Loading

Ready for review Powered by Pull Request Badge

Summary

  • Upgrade to JDK25
  • Rebuild GVM libs
  • Maven updates
  • Disable Detekt in CI (doesn't yet support JDK 25)
  • Quick Native Image testing

@sgammon sgammon added this to the Release R18: Beta milestone Sep 25, 2025
@sgammon sgammon requested a review from a team September 25, 2025 23:37
@sgammon sgammon self-assigned this Sep 25, 2025
@sgammon sgammon added feature Large PRs or issues with full-blown features lang:java Issues relating to Java language support labels Sep 25, 2025
@sgammon sgammon added this to Elide Sep 25, 2025
@sgammon sgammon moved this to In Progress in Elide Sep 26, 2025
@sgammon sgammon added dependencies Pull requests that update a dependency file ✋ embargoed PRs and issues that can't proceed because of some non-code condition and removed feature Large PRs or issues with full-blown features labels Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.62%. Comparing base (fb650ef) to head (b8fee54).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/kotlin/elide/tool/cli/cmd/dev/LspCommand.kt 0.00% 2 Missing ⚠️
...me/lang/javascript/ElideUniversalJsModuleLoader.kt 33.33% 1 Missing and 1 partial ⚠️
...main/kotlin/elide/runtime/plugins/python/Python.kt 50.00% 1 Missing and 1 partial ⚠️
...de/runtime/core/internals/graalvm/GraalVMEngine.kt 50.00% 0 Missing and 2 partials ⚠️
packages/exec/src/main/kotlin/elide/exec/Action.kt 66.66% 1 Missing ⚠️
...ges/exec/src/main/kotlin/elide/exec/Coordinator.kt 0.00% 1 Missing ⚠️
...m/src/main/kotlin/elide/runtime/plugins/jvm/Jvm.kt 50.00% 1 Missing ⚠️
.../kotlin/elide/runtime/gvm/kotlin/KotlinLanguage.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
+ Coverage   40.60%   40.62%   +0.02%     
==========================================
  Files         799      798       -1     
  Lines       37800    37774      -26     
  Branches     5387     5385       -2     
==========================================
- Hits        15347    15344       -3     
+ Misses      20628    20606      -22     
+ Partials     1825     1824       -1
Flag Coverage Δ
jvm 40.62% <55.55%> (+0.02%) ⬆️
lib 40.62% <55.55%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/exec/src/main/kotlin/elide/exec/ActionScope.kt 64.10% <100.00%> (+3.57%) ⬆️
...c/src/main/kotlin/elide/exec/TaskGraphExecution.kt 63.88% <100.00%> (ø)
...tlin/elide/runtime/intrinsics/ai/ElideLLMModule.kt 27.81% <100.00%> (+0.42%) ⬆️
packages/exec/src/main/kotlin/elide/exec/Action.kt 67.74% <66.66%> (ø)
...ges/exec/src/main/kotlin/elide/exec/Coordinator.kt 46.66% <0.00%> (-1.07%) ⬇️
...m/src/main/kotlin/elide/runtime/plugins/jvm/Jvm.kt 73.43% <50.00%> (ø)
.../kotlin/elide/runtime/gvm/kotlin/KotlinLanguage.kt 0.00% <0.00%> (ø)
...c/main/kotlin/elide/tool/cli/cmd/dev/LspCommand.kt 1.54% <0.00%> (ø)
...me/lang/javascript/ElideUniversalJsModuleLoader.kt 74.91% <33.33%> (+0.08%) ⬆️
...main/kotlin/elide/runtime/plugins/python/Python.kt 68.00% <50.00%> (-0.43%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb650ef...b8fee54. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon force-pushed the chore/jdk25 branch 2 times, most recently from d97c414 to aec7212 Compare September 26, 2025 04:19
@sgammon sgammon removed the ✋ embargoed PRs and issues that can't proceed because of some non-code condition label Sep 26, 2025
@sgammon sgammon changed the title chore: upgrade jdk25 chore: upgrade → jdk25 Sep 26, 2025
natehak
natehak reviewed Sep 26, 2025
View reviewed changes
.github/workflows/checks.detekt.yml
with:
distribution: "graalvm"
java-version: 24
java-version: "25"
Copy link
Contributor

@natehak natehak Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this become a string?

Copy link
Member Author

@sgammon sgammon Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistency; makes find/replace easy for version bumps, and the predominant expression was a string

natehak
natehak reviewed Sep 26, 2025
View reviewed changes
natehak
natehak reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@natehak natehak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think you should probably get a once over from someone maybe a little more familiar with the entire code base but nothing sticking out to me as wrong except for the change from int to string in the github workflow YML files.

@sgammon
chore: upgrade to jdk25
b8fee54 
fix: python flags for jdk25
fix: disable detekt in ci until it supports jdk25
fix: disable jvm source loader, repack truffle libs
fix: add shared espresso jar
fix: renamed jvm flags
chore: pin/upgrade java format
chore: update all relevant api pins
chore: maven updates after jdk25

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon requested a review from darvld September 26, 2025 21:21
@sgammon sgammon moved this from In Progress to Done in Elide Sep 26, 2025
@sgammon sgammon merged commit b297182 into main Sep 26, 2025
20 checks passed
@sgammon sgammon mentioned this pull request Oct 30, 2025
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natehak natehak natehak approved these changes

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

dependencies Pull requests that update a dependency file lang:java Issues relating to Java language support

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

4 participants

@sgammon @natehak @darvld