Skip to content

fix: --js:strict and benchmark symbols #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darvld merged 5 commits into from
Sep 24, 2025
Merged

fix: --js:strict and benchmark symbols #1668

darvld merged 5 commits into from
Sep 24, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Sep 24, 2025 •
edited
Loading

Ready for review Powered by Pull Request Badge

Summary

Adds necessary support infra to be able to run js-benchmarks on Elide.

@sgammon
fix(cli): implement --js:strict flag
a16dca5 
Fixes: #1667
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix(graalvm): js timer provider with build-time intrinsics
ce7e66f 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon
fix(graalvm): allow use of print statement in js
a260f2d 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added this to the Release R18: Beta milestone Sep 24, 2025
@sgammon sgammon self-assigned this Sep 24, 2025
@sgammon sgammon added bug Something isn't working module:graalvm Modules, changes, and issues relating to GraalVM module:cli CLI module issues and features lang:javascript Issues relating to JavaScript labels Sep 24, 2025
@sgammon sgammon added this to Elide Sep 24, 2025
@sgammon sgammon moved this to In Progress in Elide Sep 24, 2025
@sgammon sgammon marked this pull request as ready for review September 24, 2025 22:13
@sgammon sgammon requested a review from a team September 24, 2025 22:14
@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.59%. Comparing base (22be5d0) to head (78b8a43).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   40.58%   40.59%           
=======================================
  Files         798      799    +1     
  Lines       37803    37813   +10     
  Branches     5387     5387           
=======================================
+ Hits        15344    15351    +7     
- Misses      20633    20637    +4     
+ Partials     1826     1825    -1
Flag Coverage Δ
jvm 40.59% <100.00%> (+<0.01%) ⬆️
lib 40.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../elide/tool/cli/options/EngineJavaScriptOptions.kt 60.00% <100.00%> (+2.10%) ⬆️
.../kotlin/elide/runtime/gvm/internals/js/JsTimers.kt 65.82% <100.00%> (+0.21%) ⬆️
...time/gvm/intrinsics/BuildTimeIntrinsicsResolver.kt 100.00% <100.00%> (ø)
...in/kotlin/elide/runtime/javascript/BrowserStubs.kt 100.00% <100.00%> (ø)
...main/kotlin/elide/runtime/plugins/js/JavaScript.kt 90.83% <100.00%> (ø)
...otlin/elide/runtime/plugins/js/JavaScriptConfig.kt 90.90% <100.00%> (+0.09%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22be5d0...78b8a43. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon
fix(graalvm): inert js global alert function
b5f3a29 
Fixes: #1665
Signed-off-by: Sam Gammon <sam@elide.dev>
@darvld
chore: update api pins
78b8a43 
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
@darvld darvld merged commit db281ae into main Sep 24, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Sep 24, 2025
@sgammon sgammon mentioned this pull request Oct 30, 2025
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

bug Something isn't working lang:javascript Issues relating to JavaScript module:cli CLI module issues and features module:graalvm Modules, changes, and issues relating to GraalVM

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

Flag --js:strict has no effect Missing js benchmark symbols

3 participants

@sgammon @darvld