fix: enforce host environment access rules and correct process.env formatting #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
sgammon
approved these changes
Sep 24, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
- Coverage 40.58% 40.55% -0.04%
==========================================
Files 798 798
Lines 37803 37790 -13
Branches 5387 5387
==========================================
- Hits 15344 15325 -19
- Misses 20633 20641 +8
+ Partials 1826 1824 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a couple of fixes related to host environment variable access from guest code:
Node's
process.envnow returns the environment map installed by theEnvironmentplugin, which correctly enforces host access configuration and supports loading.envfiles, etc. This fixes #1664, which was not a failure of the env map itself, but instead an issue with formatting when writing to console or usingJSON.stringifyAdditionally, Node
processtests now verify thatenvmatches the map installed by the env plugin instead of checking against host env directly. Tests have been added to verify that theEnvironmentplugin correctly handles host access settings.