-
Notifications
You must be signed in to change notification settings - Fork 39
feat: intellij plugin enhancements #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1581 +/- ##
==========================================
- Coverage 39.83% 39.82% -0.01%
==========================================
Files 769 769
Lines 37010 37020 +10
Branches 5234 5234
==========================================
+ Hits 14742 14744 +2
- Misses 20499 20506 +7
- Partials 1769 1770 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
Signed-off-by: Dario Valdespino <dvaldespino00@gmail.com>
sgammon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic work 💯
Summary
This PR improves our Intellij plugin in a few ways, most notably by adding proper integration with the Pkl Intellij plugin:
New custom plugin repository
A custom Intellij plugin repository is now available, it contains the Elide Intellij Plugin, and a fork of the Pkl Intellij Plugin that has been patched for better compatibility with Elide projects. To use the repository and install the plugins in your IDE, follow the custom repositories guide and set the following as the repository URL:
The Elide and Pkl plugins should now appear in the "Marketplace" tab search; the icons for the plugins will not be available until they are installed, but this is a normal limitation for custom repositories. New updates to both plugins should be automatically detected by the IDE when they are published.
Issues with dependency analysis
The current version of Elide contains a bug that affects the contents of the lockfile, preventing the IDE from seeing the correct dependencies during project import; more specifically, only compile-time dependencies are written to the lockfile (and thus only those are available in the IDE), even though all dependencies are correctly downloaded.
A fix for this issue is included in this PR, however it will not be available until the next release. As a workaround, compile the Elide native CLI from source and select it in the IDE settings (Settings > Build,Execution,Deployment > Build Tools > Elide) as a custom Elide distribution to be used; for good measure, delete the Elide lockfile in the project (if it exists), so it is regenerated during project sync.