fix: static native linux build (musl) #1568
Conversation
dae32de to
86f567a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
- Coverage 39.84% 39.82% -0.02%
==========================================
Files 769 769
Lines 37010 37011 +1
Branches 5230 5232 +2
==========================================
- Hits 14745 14740 -5
- Misses 20499 20503 +4
- Partials 1766 1768 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes: #1439 Signed-off-by: Sam Gammon <sam@elide.dev>
86f567a to
35fa343
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the static native Linux build targeting musl by addressing JNI library loading compatibility issues. The changes ensure that static builds can properly handle native library dependencies without attempting to dynamically load libraries that aren't available in the static context.
- Adds conditional logic to skip JNI library loading when running in static mode
- Updates native library resolution to respect the
elide.staticJnisystem property - Prevents web and media builder features from attempting library loads during static builds
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| NativeLibraries.kt | Adds static JNI detection and conditional library loading logic |
| WebBuilderFeature.kt | Adds early return for static JNI builds to skip library loading |
| MediaBuilderFeature.kt | Adds early return for static JNI builds to skip library loading |
| WebBuilder.kt | Removes unnecessary synchronization around library loading |
Summary
At one point our musl-targeted Linux build was broken by upstream stuff; in the intervening time, we made changes which made us further incompatible with a static target. Upstream fixed their thing, and now we need to propagate fixes downstream to re-enable the static Linux native build.
As a result, this PR is small, because it only accounts for our own errors on that path. Between this and the GVM update in the last PR, our static musl build works smoothly again.