Skip to content

fix(cli): reachability metadata for jna #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 1 commit into from
Jul 20, 2025
Merged

fix(cli): reachability metadata for jna #1562

sgammon merged 1 commit into from
Jul 20, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Jul 20, 2025 •
edited
Loading

Ready for review Powered by Pull Request Badge

Summary

Restores our support for node:os by fixing our JNA/OSHI bugs.

Changelog

fix(cli): add reachability metadata for jna
fix(cli): add reachability metadata for oshi
fix(cli): restore oshi to supported version
chore: add small script to verify parameter arrays

@sgammon
fix(cli): reachability metadata for jna
622a24b 
fix(cli): add reachability metadata for jna
fix(cli): add reachability metadata for oshi
chore: add small script to verify parameter arrays

Fixes: #1556
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added this to the Release R18: Beta milestone Jul 20, 2025
@sgammon sgammon requested a review from a team July 20, 2025 01:22
@sgammon sgammon self-assigned this Jul 20, 2025
@sgammon sgammon added this to Elide Jul 20, 2025
@sgammon sgammon added bug Something isn't working lang:javascript Issues relating to JavaScript api:node Node API and stdlib labels Jul 20, 2025
@codecov
Copy link

codecov bot commented Jul 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.87%. Comparing base (0f6ff9d) to head (622a24b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   39.88%   39.87%   -0.01%     
==========================================
  Files         768      768              
  Lines       36941    36941              
  Branches     5218     5218              
==========================================
- Hits        14733    14730       -3     
- Misses      20442    20446       +4     
+ Partials     1766     1765       -1
Flag Coverage Δ
jvm 39.87% <ø> (-0.01%) ⬇️
lib 39.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f6ff9d...622a24b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit 4e2acde into main Jul 20, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this to Done in Elide Jul 20, 2025
@sgammon sgammon mentioned this pull request Sep 21, 2025
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

api:node Node API and stdlib bug Something isn't working lang:javascript Issues relating to JavaScript

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

node:os crash with CPU queries

3 participants

@sgammon @darvld