fix: set macos min version to consistent 15.0 value
#1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: macos minimum value isn't consistent fix: missing libs for macos Signed-off-by: Sam Gammon <sam@elide.ventures>
32a5e05 to
3b6c010
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
=======================================
Coverage 39.87% 39.87%
=======================================
Files 768 768
Lines 36941 36941
Branches 5218 5218
=======================================
Hits 14730 14730
Misses 20446 20446
Partials 1765 1765
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Rust's macOS minimum version target, which was being set to the host version; it is now set to
15.0, aligning with our CFLAGS.Note that
15.0may not be the optimal version we should land on, but now at least it's consistent.