Skip to content

Conversation

@melodicore
Copy link
Member

@melodicore melodicore commented Jul 14, 2025

Ready for review Powered by Pull Request Badge

Summary

Using common kotlin compiler arguments causes a runtime reflection issue.

fixes #1538

Changelog

  • fix: register CommonCompilerArguments methods for runtime reflection

@melodicore melodicore requested a review from sgammon as a code owner July 14, 2025 19:08
Signed-off-by: melodicore <datafox@datafox.me>
@melodicore melodicore force-pushed the fix/kotlinc-common-args branch from 2d64679 to 1a2ae06 Compare July 14, 2025 19:11
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.47%. Comparing base (b409f52) to head (1a2ae06).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
+ Coverage   40.44%   40.47%   +0.02%     
==========================================
  Files         749      749              
  Lines       35329    35329              
  Branches     4968     4968              
==========================================
+ Hits        14290    14299       +9     
+ Misses      19336    19326      -10     
- Partials     1703     1704       +1     
Flag Coverage Δ
jvm 40.47% <ø> (+0.02%) ⬆️
lib 40.47% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b409f52...1a2ae06. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit 3238988 into main Jul 14, 2025
18 checks passed
@elidebot elidebot mentioned this pull request Jul 19, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kotlinc: Elide kotlinc fails when compiler arguments are passed that are shared between kotlin compilers (jvm, js etc)

3 participants