fix(cli): don't prefix emissions from console.log
#1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
+ Coverage 40.44% 40.47% +0.03%
==========================================
Files 749 749
Lines 35325 35325
Branches 4967 4967
==========================================
+ Hits 14287 14299 +12
+ Misses 19336 19322 -14
- Partials 1702 1704 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unintended elide prefix from console outputs in the CLI’s logging configuration.
- Strips the
%magenta(elide)prefix from the console appender pattern - Ensures raw
console.logoutput is emitted without additional labels
Comments suppressed due to low confidence (2)
packages/cli/src/main/resources/logback.xml:42
- Add or update tests or integration tests to verify that console output from
console.logis no longer prefixed withelide. This will help catch regressions if the logging configuration changes again.
<pattern>%msg%n</pattern>
packages/cli/src/main/resources/logback.xml:42
- [nitpick] Consider updating the project documentation (e.g., README or CLI usage guide) to note that console logs are now emitted without the
elideprefix, so users know what to expect.
<pattern>%msg%n</pattern>
Signed-off-by: Sam Gammon <sam@elide.dev>
2105f85 to
fc791e5
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the errant
elideprefix onconsole.*output.