chore: drop elide-uuid, apply dependency updates
#1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the custom elide-uuid module, transitions UUID and timestamp handling in the CLI tools to built-in types, and bumps numerous dependencies across the build scripts, NPM packages, and Rust crates.
- Drop
elide-uuidand switch all code to useelide.util.UUID(String) and epoch-millisecond timestamps. - Update Kotlin build constants (
JVM_DEFAULT,GRAALVM_METADATA) and Micronaut versions. - Bump NPM (
esbuild,@biomejs/biome, etc.), Cargo (orogene,oxc,uv,ruff,sysinfo), and Bun versions.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/elide-build/src/main/kotlin/elide/internal/conventions/Constants.kt | Lowered JVM_DEFAULT to “21” and bumped GRAALVM_METADATA. |
| packages/cli/src/main/kotlin/elide/tool/err/PersistedError.kt | Changed timestamp from Instant to Long and id to String. |
| packages/cli/src/main/kotlin/elide/tool/err/ErrorTests.kt | Replaced uuid4() with UUID.random(). |
| packages/cli/src/main/kotlin/elide/tool/err/ErrorHandler.kt | Switched uuid to String and timestamp to Long. |
| packages/cli/src/main/kotlin/elide/tool/err/DefaultStructuredErrorRecorder.kt | Updated error‐file naming to use raw millisecond timestamp. |
| packages/base/src/jvmMain/kotlin/elide/util/UUID.kt | Replaced dev.elide.uuid.uuid4() with java.util.UUID.randomUUID(). |
| packages/base/build.gradle.kts | Removed elide.uuid dependency. |
| package.json | Bumped various NPM dependencies (esbuild, @biomejs/biome, etc.). |
| package-lock.kdl | Synced lockfile entries with NPM bumps. |
| gradle/elide.versions.toml | Dropped elide-uuid entries; bumped GraalVM metadata, CSS wrappers, Micronaut. |
| gradle.properties | Bumped micronautVersion to 4.9.1. |
| crates/js/src/precompiler.rs | Switched to new CommentOptions API for Oxc codegen. |
| config/bun-version | Bumped Bun CLI image to 1.2.18. |
| Cargo.toml | Updated orogene, oxc, uv, ruff, and sysinfo revisions. |
Comments suppressed due to low confidence (2)
packages/base/src/jvmMain/kotlin/elide/util/UUID.kt:24
- [nitpick] This change causes UUIDs to be emitted in uppercase; consider adding a KDoc comment or noting in the README that consumers should expect uppercase (with hyphens) to avoid interoperability confusion.
return java.util.UUID.randomUUID().toString().uppercase()
gradle.properties:86
- [nitpick] Consider updating
micronautCatalogVersionto match the bumpedmicronautVersion(4.9.1) to keep your BOM and actual dependency versions in sync.
micronautCatalogVersion = 4.5.4
tools/elide-build/src/main/kotlin/elide/internal/conventions/Constants.kt
Show resolved
Hide resolved
packages/cli/src/main/kotlin/elide/tool/err/DefaultStructuredErrorRecorder.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
- Coverage 41.04% 41.04% -0.01%
==========================================
Files 733 733
Lines 34525 34531 +6
Branches 4862 4862
==========================================
Hits 14172 14172
- Misses 18663 18669 +6
Partials 1690 1690
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Sam Gammon <sam@elide.dev>
chore: upgrade micronaut → `4.9.7` fix: hold `micronaut-http-netty` back at `4.8.18` Relates-to: micronaut-projects/micronaut-core#11941 Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
a7ba583 to
cbc69a9
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some light cleaning and dependency updates.
elide-uuid, which is no longer needed4.9.7