feat: implement node util
#1527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(node): implement `util.promisify` feat(node): implement `util.callbackify` feat(node): mount `TextEncoder` and `TextDecoder` test(node): add initial tests for `util` module chore: update `graalvm` api pins chore: apply patch for `JSPromiseObject` use to `truffle-api` Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): implement debug logger facade + behavior feat(cli): implement `--js:debug` flag support for js debug logging test(cli): activation of `--js:debug` logging chore: update serialized logging config chore: update `graalvm` module pins Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): add `DeprecatedCallable` which warns on first use feat(node): implement `util.deprecate` method test(node): simple tests for `util.deprecate` Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): implement `transferableAbortController` feat(node): implement `transferableAbortSignal` test(node): simple tests for transferable abort signal/controller methods chore: update `graalvm` module pins Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): implement `util.MIMEType` class feat(node): implement `util.MIMEParams` class test(node): tests for MIME type parsing Signed-off-by: Sam Gammon <sam@elide.dev>
ce3cf53 to
fc11a17
Compare
Closed
Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): implement `util.getSystemErrorName` feat(node): implement `util.getSystemErrorMap` test(node): tests for system error methods in `util` Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): most type checks on `util.types` test(node): tests for `util.types` Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): add `InspectOptions` and impl feat(node): add `util.inspect` for primitives feat(node): add `util.inspect` for host-side complex types (pt 1) feat(node): add `util.inspect` for guest-side complex types (pt 1) test(node): tests for `util.inspect` Signed-off-by: Sam Gammon <sam@elide.dev>
feat(node): implement primitive `util.format` support chore(node): move object inspection to dedicated file test(node): primitive `util.format` tests Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a first-pass implementation of Node’s util module on GraalVM, including the full host-side NodeUtil API, support for formatting and inspection (util.format, inspect, formatWithOptions), type-checking helpers (util.types), debug logging, deprecation wrappers, and MIME type utilities, alongside a comprehensive suite of Kotlin tests.
- Introduces
NodeUtilwith callbackify/promisify, debuglog/deprecate, inspect/format, error name lookup, abort controllers, MIME types, and typechecks - Implements host-side formatting via
StringFormatterand inspection viaObjectInspectorwith fullInspectOptionssupport - Adds exhaustive tests in
NodeUtilTest.ktand necessary test harness improvements (executeESM)
Reviewed Changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/graalvm/src/main/kotlin/elide/runtime/node/util/NodeUtil.kt | Core util module implementation (callbackify, inspect, etc.) |
| packages/graalvm/src/main/kotlin/elide/runtime/node/util/NodeTypechecks.kt | util.types.* methods implemented |
| packages/graalvm/src/main/kotlin/elide/runtime/node/util/StringFormatter.kt | Implements %-based formatting logic |
| packages/graalvm/src/test/kotlin/elide/runtime/node/NodeUtilTest.kt | Comprehensive test suite covering all util APIs |
packages/graalvm/src/main/kotlin/elide/runtime/node/util/NodeTypechecks.kt
Outdated
Show resolved
Hide resolved
darvld
approved these changes
Jul 10, 2025
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Relates-to: elide-dev/runtime#383 Signed-off-by: Sam Gammon <sam@elide.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First pass at implementing Node's
utilmodule.util#1203callbackifypromisifyisArraydebuglogdeprecatetransferableAbort{Controller,Signal}TextEncoder/TextDecoderconstructorsMIMETypeMIMEParamsgetSystemErrorNamegetSystemErrorMapinheritsformat%s%i,%d,%f%j,%o,%O)formatWithOptionscolorsmaxArrayItemsmaxStringLengthEnforcement ofnote: ishdepthinspectList,Set,Map[ ... ],{ ... }(lists and sets)typesisAnyArrayBufferisArrayBufferViewisArgumentsObjectisArrayBufferisAsyncFunctionisBigInt64ArrayisBigIntObjectisBigUint64ArrayisBooleanObjectisDateisFloat16ArrayisFloat32ArrayisFloat64ArrayisGeneratorFunctionisInt8ArrayisInt16ArrayisInt32ArrayisMapisNumberObjectisPromiseisRegExpisSetisSharedArrayBufferisStringObjectisSymbolObjectisTypedArrayisUint8ArrayisUint8ClampedArrayisUint16ArrayisUint32ArrayisWeakMapisWeakSet