Skip to content

feat: build jars by default for jvm projects #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 1 commit into from
Jul 2, 2025
Merged

feat: build jars by default for jvm projects #1518

sgammon merged 1 commit into from
Jul 2, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Jul 2, 2025 •
edited by pull-request-badge bot
Loading

Ready for review Powered by Pull Request Badge

Summary

Add a task to build a JAR when all the following conditions are true:

  1. We are configuring a build for an Elide project
  2. It is a JVM project (i.e. it uses Java or Kotlin)
  3. It does not have any JAR task configured which consumes the main source set

@sgammon
feat: build jars by default for jvm projects
d94e385 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added this to the Release R18: Beta milestone Jul 2, 2025
@sgammon sgammon requested a review from a team July 2, 2025 21:37
@sgammon sgammon self-assigned this Jul 2, 2025
@sgammon sgammon added enhancement New feature or request lang:java Issues relating to Java language support labels Jul 2, 2025
@sgammon sgammon added this to Elide Jul 2, 2025
@sgammon sgammon added the lang:kotlin Related to Kotlin lang support label Jul 2, 2025
@sgammon sgammon moved this to In Progress in Elide Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 40.17%. Comparing base (6078f29) to head (d94e385).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...n/kotlin/elide/tooling/jvm/JarBuildConfigurator.kt 0.00% 23 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   40.20%   40.17%   -0.03%     
==========================================
  Files         701      701              
  Lines       32830    32853      +23     
  Branches     4569     4575       +6     
==========================================
  Hits        13200    13200              
- Misses      18082    18105      +23     
  Partials     1548     1548
Flag Coverage Δ
jvm 40.17% <0.00%> (-0.03%) ⬇️
lib 40.17% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/kotlin/elide/tooling/jvm/JarBuildConfigurator.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6078f29...d94e385. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit 20351b4 into main Jul 2, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Jul 2, 2025
@elidebot elidebot mentioned this pull request Jul 19, 2025
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

enhancement New feature or request lang:java Issues relating to Java language support lang:kotlin Related to Kotlin lang support

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

3 participants

@sgammon @darvld