Skip to content

fix: elide init flags and conveniences #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 2 commits into from
Jul 2, 2025
Merged

fix: elide init flags and conveniences #1517

sgammon merged 2 commits into from
Jul 2, 2025

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Jul 2, 2025 •
edited by pull-request-badge bot
Loading

Ready for review Powered by Pull Request Badge

Summary

Small conveniences and fixes for elide init.

Changelog

fix: don't prompt about overwrite for empty dirs
chore: add `--yes` flag to `elide init`
chore: properly enforce `--force` flag

@sgammon
fix: elide init flags and conveniences
2331d66 
fix: don't prompt about overwrite for empty dirs
chore: add `--yes` flag to `elide init`
chore: properly enforce `--force` flag

Relates to #1514

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added this to the Release R18: Beta milestone Jul 2, 2025
@sgammon sgammon requested a review from a team July 2, 2025 21:11
@sgammon sgammon self-assigned this Jul 2, 2025
@sgammon sgammon added this to Elide Jul 2, 2025
@sgammon sgammon added bug Something isn't working module:cli CLI module issues and features labels Jul 2, 2025
@sgammon sgammon moved this to In Progress in Elide Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.17%. Comparing base (6078f29) to head (7670a9f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...main/kotlin/elide/tool/cli/cmd/init/InitCommand.kt 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1517      +/-   ##
==========================================
- Coverage   40.20%   40.17%   -0.03%     
==========================================
  Files         701      701              
  Lines       32830    32827       -3     
  Branches     4569     4570       +1     
==========================================
- Hits        13200    13189      -11     
- Misses      18082    18090       +8     
  Partials     1548     1548
Flag Coverage Δ
jvm 40.17% <20.00%> (-0.03%) ⬇️
lib 40.17% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/main/kotlin/elide/tool/cli/AbstractSubcommand.kt 57.66% <100.00%> (-0.35%) ⬇️
...main/kotlin/elide/tool/cli/cmd/init/InitCommand.kt 3.08% <0.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6078f29...7670a9f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon
fix: disable telemetry without init issues
7670a9f 
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the fix/init-command-flags branch from dab6260 to 7670a9f Compare July 2, 2025 21:39
@sgammon sgammon merged commit 79f535b into main Jul 2, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Elide Jul 2, 2025
@elidebot elidebot mentioned this pull request Jul 19, 2025
Merged
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darvld darvld darvld approved these changes

Assignees

@sgammon sgammon

Labels

bug Something isn't working module:cli CLI module issues and features

Projects

Elide
Status: Done

Milestone

Release R18: Beta

Development

Successfully merging this pull request may close these issues.

3 participants

@sgammon @darvld