Skip to content

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Jun 30, 2025

Ready for review Powered by Pull Request Badge

Summary

Bunch of general fixes and improvements, plus initial datamodel for awareness re/Gradle Module Metadata.

  • Lib Publishing Fixes
    • Fix library publishing conventions (Maven)
    • New deploy script which pushes 3p libs to Elide's Maven repo
  • Installer Enhancements
    • Installer: Source and Doc JARs #1513
    • Initial model for Gradle Module Metadata awareness
    • Add --with=sources and --with=docs to elide install
    • Fetch Gradle Module Metadata alongside POMs
  • Builder Enhancements
    • Ability to control optimization level + push/deploy state
      • Add --mode and --[no-]deploy flags to elide build
      • Honor new flags for native-image builder
      • Honor new flags for container builder

@sgammon sgammon added this to the Release R18: Beta milestone Jun 30, 2025
@sgammon sgammon self-assigned this Jun 30, 2025
@sgammon sgammon added feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge tools Issues and PRs related to tooling labels Jun 30, 2025
@sgammon sgammon added this to Elide Jun 30, 2025
@sgammon sgammon added the tools:install Things related to Elide's dependency installer label Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 15.59633% with 368 lines in your changes missing coverage. Please review.

Project coverage is 40.25%. Comparing base (4e26cf3) to head (afc6e4d).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...n/elide/tooling/jvm/gradle/GradleModuleMetadata.kt 25.75% 84 Missing and 14 partials ⚠️
...n/kotlin/elide/tooling/jvm/JvmBuildConfigurator.kt 0.00% 58 Missing ⚠️
.../elide/tooling/jvm/resolver/MavenAetherResolver.kt 0.00% 32 Missing ⚠️
...e/tooling/containers/ContainerBuildConfigurator.kt 0.00% 29 Missing ⚠️
...kotlin/elide/tool/project/DefaultProjectManager.kt 55.55% 13 Missing and 7 partials ⚠️
...e/tooling/project/manifest/ElidePackageManifest.kt 10.52% 17 Missing ⚠️
...n/kotlin/elide/tooling/config/BuildConfigurator.kt 0.00% 16 Missing ⚠️
...n/elide/tool/cli/cmd/project/ToolProjectCommand.kt 0.00% 16 Missing ⚠️
...lin/elide/tool/cli/cmd/builder/ToolBuildCommand.kt 12.50% 14 Missing ⚠️
...tooling/src/main/kotlin/elide/tooling/BuildMode.kt 0.00% 12 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   41.99%   40.25%   -1.75%     
==========================================
  Files         680      701      +21     
  Lines       31366    32775    +1409     
  Branches     4386     4557     +171     
==========================================
+ Hits        13172    13192      +20     
- Misses      16627    18040    +1413     
+ Partials     1567     1543      -24     
Flag Coverage Δ
jvm 40.25% <15.59%> (-1.75%) ⬇️
lib 40.25% <15.59%> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/main/kotlin/elide/tool/cli/AbstractSubcommand.kt 58.00% <100.00%> (+0.61%) ⬆️
.../src/main/kotlin/elide/tooling/jvm/JavaCompiler.kt 0.00% <0.00%> (ø)
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 35.22% <50.00%> (-0.47%) ⬇️
...kotlin/elide/tooling/project/ProjectEnvironment.kt 0.00% <0.00%> (ø)
...lide/tooling/jvm/resolver/MavenLockfileResolver.kt 73.33% <0.00%> (ø)
...ain/kotlin/elide/tooling/lockfile/ElideLockfile.kt 0.00% <0.00%> (-34.60%) ⬇️
.../main/kotlin/elide/tooling/project/ElideProject.kt 0.00% <0.00%> (ø)
...otlin/elide/tooling/jvm/gradle/GradleAttributes.kt 28.57% <28.57%> (ø)
...n/kotlin/elide/tool/cli/cmd/deps/InstallCommand.kt 5.45% <16.66%> (+1.49%) ⬆️
...tooling/src/main/kotlin/elide/tooling/MultiPath.kt 15.74% <0.00%> (ø)
... and 14 more

... and 175 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905156a...afc6e4d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon force-pushed the chore/lib-publishing-fixes branch 2 times, most recently from 770aa7c to e6037b4 Compare July 1, 2025 01:51
@sgammon sgammon changed the title [WIP] feat: gradle module metadata feat: gradle module metadata Jul 1, 2025
@sgammon sgammon marked this pull request as ready for review July 1, 2025 14:56
@sgammon sgammon moved this to In Progress in Elide Jul 1, 2025
Copy link
Member Author

@sgammon sgammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

@claude

This comment was marked as outdated.

@claude

This comment was marked as outdated.

@sgammon sgammon linked an issue Jul 2, 2025 that may be closed by this pull request
sgammon added 12 commits July 2, 2025 08:00
fix: publishing to local stage dir
fix: drop github repo target
fix: publishing to internal maven repo
fix: align protobuf with sigstore
chore: author poms for overridden libs
chore: publishing script for 3p libs
chore: end-to-end publishing script

Signed-off-by: Sam Gammon <sam@elide.dev>
feat: add `--mode` flag to `elide build`
feat: add `--deploy` flag to `elide build`
feat: honor flags for mode and deploy

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
feat: support for `processors` maven block
feat: assemble and include processor classpath
feat: greatest-common-ancestor for `--source-path`

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
sgammon added 3 commits July 2, 2025 08:00
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the chore/lib-publishing-fixes branch from 39a7a04 to 35d179e Compare July 2, 2025 15:03
@sgammon sgammon removed the 🚧 WIP Works-in-progress. Blocks merge label Jul 2, 2025
@sgammon sgammon requested a review from a team July 2, 2025 15:31
@sgammon sgammon moved this from In Progress to Done in Elide Jul 2, 2025
Fixes #1515
Fixes #1502

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the chore/lib-publishing-fixes branch from 372aacc to afc6e4d Compare July 2, 2025 15:47
@sgammon sgammon merged commit ce60c15 into main Jul 2, 2025
18 checks passed
@elidebot elidebot mentioned this pull request Jul 19, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Large PRs or issues with full-blown features tools:install Things related to Elide's dependency installer tools Issues and PRs related to tooling

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

elide kotlinc/javac --no-telemetry fails with an exception Installer: Source and Doc JARs Telemetry shouldn't lag build/test commands

3 participants