Feature/add pragma support #487
Merged
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliben
requested changes
Jan 7, 2023
Owner
eliben
left a comment
There was a problem hiding this comment.
Thank you; please rebase this PR on top of the current master - it had a commit that should fix action failures on old Python versions
32b3503 to
07c5454
Compare
eliben
requested changes
Jan 7, 2023
08d6083 to
0fcd501
Compare
Contributor
Author
|
Thanks for the help! Looks good to me now. |
eliben
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #485 for _Pragma support.
After the preprocessing stage, some
_Pragmas may remain. This at least lets us parse such code.I'm not certain about the
_token_coord(p, 2))here though. Might be 3?https://github.com/statinf-software/pycparser/blob/32b35034bf06d76af10054da8cc227b9e6dd75dd/pycparser/c_parser.py#L579-L580
(PS: I get
ModuleNotFoundError: No module named '_ast_gen'when trying to run the tests, but I think the test additions still ran and passed.)