Added filter for content in Element_Base#6433
Added filter for content in Element_Base#6433thenovacreator wants to merge 3 commits intoelementor:release/2.4.0from
Conversation
|
We need this to implement a cache buster for our "splittest for elementor" plugin. |
|
@thenovacreator The correct syntax should be: You should apply filter on the variable you are filtering. Also, it would be better to move this filter to line 663, where you define the |
|
Do you recommend it like this? |
|
What about this to be merged? |
|
Is there something new going on here? Wo really need this as it stops us from developing your plugins further. |
|
+1 -- without this is not possible to exclude test content from the site's caching |
|
+1 - without this, the plugin is almost useless for most sites that are interested in performance as well as marketing. Almost all users that are looking at A/B testing will have some sort of caching in place i would guess |
|
Would love this, too! |
|
+1 Have been waiting forever for there to be a split testing option for Elementor. I have been using Thrive Themes specifically because of their A / B split testing functionality. I was thrilled to see a plugin for split testing with Elementor... and then disappointed that it won't work with WP Rocket or other caching plugins enabled. Disabling caching is not an option. Looking forward to being able to split test with Elementor. |
|
+1 Please Elementor Team, make our lifes even easier.. |
|
I can not understand how things went here. Except of the syntax correction there were almost no comments of the elementor team here. In contrast to the other users posting here that they would love to have this. And then without any comment or hint for a solution (how ever this solution could look like) and any word about why this request is closed it is closed. That is really sad because without this we have really big issues to develop our plugin further. We may stop developing it since really useful features would be depend on this and without that ... well what should we develop. And do not think that we did not care about this. But instead of bugging we think that the users voices in here would be enough. |
|
It could be that just nobody noticed or, more likely, they want to save the solution for themselves, and rather than help you, end up as your competitor. I don't know this is true, its just an idea, so just saying what I think might be what's happening. |
|
I'm also interested in seeing this implemented. |
|
We really need this to be implemented, too. |
|
@hsk-it commented on Jul 19, 2019, 10:30 PM GMT+3:
@RichardUUU commented on Jul 19, 2019, 10:21 PM GMT+3:
@TerenceMilbourn commented on Jul 19, 2019, 4:17 PM GMT+3:
@thenovacreator commented on Jul 19, 2019, 12:56 AM GMT+3:
@backpackerstoday commented on Jul 6, 2019, 2:12 PM GMT+3:
@WebZenStudio commented on Jun 28, 2019, 8:59 PM GMT+3:
Hi everyone, This was closed via External Software, hence the lack of explanation, but not by accident. We closed this Mainly for the performance and resources hit it would cause passing each and every element ( section, column, widget) output via a filter. Also, there are already hooks in place that allow manipulating the output: elementor/includes/base/element-base.php Lines 519 to 529 in 8bfc36f elementor/includes/base/element-base.php Lines 530 to 542 in 8bfc36f elementor/includes/base/element-base.php Lines 572 to 584 in 8bfc36f elementor/includes/base/element-base.php Lines 585 to 594 in 8bfc36f |
|
Thanks for the comment. The inital Problem is that all the hooks you are presenting here are not working for this case. I need to manipulate the html content directly. So now i have to use the "elementor/frontend/section/should_render" event and this code To get things working |
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
-> Documentation should be extended according to this https://code.elementor.com/php-hooks/#elementorwidgetrender_content.