Internal: Scripting the beta release process [ED-20063] by Ntnelbaba · Pull Request #31873 · elementor/elementor

Ntnelbaba · 2025-07-15T09:43:31Z

PR Checklist

The commit message follows our guidelines: https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

Summary

This PR can be summarized in the following changelog entry:

Description

An explanation of what is done in this PR

Test instructions

This PR can be tested by following these steps:

Quality assurance

I have tested this code to the best of my abilities
I have added unittests to verify the code works as intended
Docs have been added / updated (for bug fixes / features)

Fixes #

✨ PR Description

Purpose: Add automation script for the beta release process to streamline version management and branch creation workflows.

Main changes:

Added prepare-beta-release.sh script to automate branch creation and version bumping for beta releases
Created npm release-beta command to execute the automation script with proper permissions
Implemented version calculations and configurable dry-run mode with interactive prompts

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}

github-actions · 2025-07-15T09:51:16Z

Elementor Build

Last updated at: 20250715.1048
Version: 3.31.0-20250715.1048

✅ Elementor build is ready for download.

You can download the latest build from the link below:

🔗 elementor-3.31.0-20250715.1048.zip

The build is available for 3 days.

Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>

gitstream-cm

✨ PR Review

The shell script implementation addresses the chmod security issue from previous reviews, but the critical variable expansion problem in sed commands remains unresolved and will prevent the script from functioning correctly.

1 issues detected:

🐞 Bug - Variables in single-quoted strings are not expanded by the shell, causing literal text replacement instead of variable substitution.

Details: Shell variables within sed commands are not properly expanded due to single quote usage in the replacement patterns. The script will insert literal '$DEV_VERSION' text instead of the actual version value when updating files.
File: scripts/prepare-beta-release.sh (81-82)

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}

gitstream-cm · 2025-07-15T10:49:09Z

scripts/prepare-beta-release.sh

+    execOrLog "sed -i '' -E 's/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/' elementor.php"
+    execOrLog "sed -i '' -E 's/(define\( 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'\)/\1$DEV_VERSION'\)/' elementor.php"


🐞 Bug - Variable Expansion Issue: Use double quotes for the sed command and properly escape the variable expansion, or use a different approach like separate variable assignment before the sed command.

Suggested change

execOrLog "sed -i '' -E 's/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/' elementor.php"

execOrLog "sed -i '' -E 's/(define$ 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'$/\1$DEV_VERSION'\)/' elementor.php"

execOrLog "sed -i '' -E \"s/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/\" elementor.php"

execOrLog "sed -i '' -E \"s/(define$ 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'$/\1$DEV_VERSION'\)/\" elementor.php"

gitstream-cm

✨ PR Review

The beta release script implementation is comprehensive with good error handling and dry-run functionality, but contains a critical variable expansion issue in the sed commands that will prevent proper version updates.

1 issues detected:

🐞 Bug - Single quotes prevent shell variable expansion in sed replacement patterns

Details: The sed commands use single quotes around the replacement pattern which prevents shell variable expansion. The script will update version strings with literal '$DEV_VERSION' instead of the actual version value, causing incorrect version updates in elementor.php.
File: scripts/prepare-beta-release.sh (81-82)

Generated by LinearB AI and added by gitStream.
_{AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀}

gitstream-cm · 2025-07-15T10:50:10Z

scripts/prepare-beta-release.sh

+    execOrLog "sed -i '' -E 's/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/' elementor.php"
+    execOrLog "sed -i '' -E 's/(define\( 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'\)/\1$DEV_VERSION'\)/' elementor.php"


🐞 Bug - Variable Expansion Issue: Replace single quotes with double quotes in the sed replacement patterns, or use string concatenation to properly expand the $DEV_VERSION variable.

Suggested change

execOrLog "sed -i '' -E 's/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/' elementor.php"

execOrLog "sed -i '' -E 's/(define$ 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'$/\1$DEV_VERSION'\)/' elementor.php"

execOrLog "sed -i '' -E \"s/(\\* Version: )[0-9]+\\.[0-9]+\\.[0-9]+(-[a-z0-9]+)?/\\1$DEV_VERSION/\" elementor.php"

execOrLog "sed -i '' -E \"s/(define\$ 'ELEMENTOR_VERSION', ')[0-9]+\\.[0-9]+\\.[0-9]+(-[a-z0-9]+)?'\$/\\1$DEV_VERSION'\\)/\" elementor.php"

Internal: Scripting the beta release process [ED-20063]

31df560

This comment was marked as resolved.

Sign in to view

Ntnelbaba requested review from Svitlana-Dykun and TzviRabinovitch July 15, 2025 09:45

gitstream-cm bot added the 10 min review label Jul 15, 2025

Create branch only on main (and allow changes to release or main)

e8b3318

This comment was marked as resolved.

Sign in to view

gitstream-cm bot added 🚨 1 Unresolved Thread(s) and removed 🚨 1 Unresolved Thread(s) labels Jul 15, 2025

Svitlana-Dykun previously approved these changes Jul 15, 2025

View reviewed changes

Fix logic

49aeae0

Ntnelbaba dismissed Svitlana-Dykun’s stale review via 49aeae0 July 15, 2025 10:22

This comment was marked as resolved.

Sign in to view

gitstream-cm bot added the 🚨 1 Unresolved Thread(s) label Jul 15, 2025

Support only main

4d1ed96

Ntnelbaba requested a review from Svitlana-Dykun July 15, 2025 10:46

Update package.json

47c5153

Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view

Update scripts/prepare-beta-release.sh

a582858

Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>

gitstream-cm bot reviewed Jul 15, 2025

View reviewed changes

gitstream-cm bot removed the 🚨 1 Unresolved Thread(s) label Jul 15, 2025

gitstream-cm bot reviewed Jul 15, 2025

View reviewed changes

TzviRabinovitch approved these changes Jul 15, 2025

View reviewed changes

gitstream-cm bot added the 🚨 2 Unresolved Thread(s) label Jul 15, 2025

Ntnelbaba merged commit 6cfd95f into main Jul 15, 2025
39 of 40 checks passed

Ntnelbaba deleted the ED-20063-scripting-beta-release-process branch July 15, 2025 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Internal: Scripting the beta release process [ED-20063]#31873

Internal: Scripting the beta release process [ED-20063]#31873
Ntnelbaba merged 6 commits intomainfrom
ED-20063-scripting-beta-release-process

Ntnelbaba commented Jul 15, 2025 •

edited by gitstream-cm bot

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

gitstream-cm bot left a comment

Uh oh!

gitstream-cm bot Jul 15, 2025

Uh oh!

gitstream-cm bot left a comment

Uh oh!

gitstream-cm bot Jul 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		execOrLog "sed -i '' -E 's/(\* Version: )[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?/\1$DEV_VERSION/' elementor.php"
		execOrLog "sed -i '' -E 's/(define\( 'ELEMENTOR_VERSION', ')[0-9]+\.[0-9]+\.[0-9]+(-[a-z0-9]+)?'\)/\1$DEV_VERSION'\)/' elementor.php"

Conversation

Ntnelbaba commented Jul 15, 2025 • edited by gitstream-cm bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

Summary

Description

Test instructions

Quality assurance

✨ PR Description

Uh oh!

This comment was marked as resolved.

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Elementor Build

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

gitstream-cm bot left a comment

Choose a reason for hiding this comment

✨ PR Review

Uh oh!

gitstream-cm bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

gitstream-cm bot left a comment

Choose a reason for hiding this comment

✨ PR Review

Uh oh!

gitstream-cm bot Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ntnelbaba commented Jul 15, 2025 •

edited by gitstream-cm bot

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading